Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Remove the -Xdoclint parameter in pom.xml fix #1106 #1107

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Jan 11, 2017

Remove the -Xdoclint parameter in pom.xml to show errors related to javadoc using java 8 rules. Travis should fail when those errors occured. Fix #1106

@monperrus
Copy link
Collaborator

Travis should fail when those errors occured.

are you sure, did you try? it seems this is only an output setting. what about the "quiet"?

@surli
Copy link
Collaborator Author

surli commented Jan 11, 2017

are you sure, did you try? it seems this is only an output setting. what about the "quiet"?

Actually I tried: when I proposed this PR, #1105 wasn't merged yet and I obtained a failing build for this PR: I launched it back after the merge to be sure it has the correct behaviour.

I assume the quiet is here to display only few messages, but it does show the warnings.

@surli
Copy link
Collaborator Author

surli commented Jan 12, 2017

@monperrus as you can see it works: #1090 introduces some javadoc JDK8 errors ;)

@monperrus
Copy link
Collaborator

monperrus commented Jan 12, 2017 via email

@surli
Copy link
Collaborator Author

surli commented Jan 12, 2017

so we need a new PR on the doc, before being able to merge this one, right?

I'm doing it. I push it in 5 minutes.

@monperrus monperrus merged commit 30540e5 into INRIA:master Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants