Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix issues related to javadoc in java 8 #1104 #1105

Merged
merged 4 commits into from
Jan 11, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Jan 11, 2017

Fix all errors encountered while launching mvn javadoc:javadoc on Spoon. Lot of warnings are still remaining but don't block the goal.

@@ -241,6 +241,11 @@
<artifactId>commons-io</artifactId>
<version>1.4</version>
</dependency>
<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a test dependency.
Please specify the scope of the dependency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tdurieux
Copy link
Collaborator

tdurieux commented Jan 11, 2017

Maybe it is a good idea that spoon encodes (printing) and decodes (parsing) the comments.
What do you think?

@surli
Copy link
Collaborator Author

surli commented Jan 11, 2017

Maybe it is a good idea that spoon encodes and decodes the comments.

Encodes when building model and decodes when pretty-printing?
I'm not sure about the benefits of doing that, but still it should be in another issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants