Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: Update Local Unit edit, validation, and delete workflow #1593

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

shreeyash07
Copy link
Collaborator

@shreeyash07 shreeyash07 commented Dec 19, 2024

Addresses:

Depends

IFRCGo/go-api#2346

Changes

  • Show local units form changes in modal
  • Show changes in form fields
  • Add revert button and revert reason, modal and form while validating
  • Add delete button and delete reason, modal in local unit form and local unit table action

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 5d77bc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
go-web-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samshara samshara force-pushed the project/local-unit-v2 branch from 6d24ec0 to 08c1d9a Compare December 20, 2024 06:09
@tnagorra tnagorra changed the title Update Local Unit edit, validation, and delete workflow Project: Update Local Unit edit, validation, and delete workflow Dec 24, 2024
@tnagorra tnagorra changed the title Project: Update Local Unit edit, validation, and delete workflow project: Update Local Unit edit, validation, and delete workflow Dec 27, 2024
@samshara samshara marked this pull request as draft January 9, 2025 12:11
@frozenhelium frozenhelium force-pushed the project/local-unit-v2 branch 3 times, most recently from c7e4138 to b745def Compare January 13, 2025 06:05
@frozenhelium frozenhelium marked this pull request as ready for review January 13, 2025 06:06
@frozenhelium frozenhelium force-pushed the project/local-unit-v2 branch from b745def to c37f7b0 Compare January 13, 2025 06:23
@frozenhelium frozenhelium force-pushed the project/local-unit-v2 branch from c37f7b0 to 67bde0b Compare January 13, 2025 07:03
- feat(local-units): add delete modal and refine permissions
- Add delete modal in Local Units Form and Local Units Table
- Separate delete and validate permissions for local units
- Simplify delete permission logic
- Remove unused files from utils/common
@samshara samshara merged commit c97ef9f into develop Jan 13, 2025
14 checks passed
@samshara samshara deleted the project/local-unit-v2 branch January 13, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants