Skip to content

fix(browser): remove --no-sandbox and persist profile across restarts #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yalexx merged 2 commits into from
Apr 21, 2026
Merged

fix(browser): remove --no-sandbox and persist profile across restarts #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcb8ce3
fix(browser): remove --no-sandbox and persist profile across restarts
yalexx Apr 21, 2026
3f021fa
browser fix
yalexx Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ code-source-code/
.omx/
playwright-report/
test-results/
scripts/nm-dispatcher-failover.sh

@coderabbitai coderabbitai Bot Apr 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Do not ignore a script required by installer packaging

Line 21 ignores scripts/nm-dispatcher-failover.sh, but install.sh consumes this file as a source artifact (install.sh:1-100). This can cause missing-file install failures if the script is not tracked in future commits/releases.

Suggested fix 
-scripts/nm-dispatcher-failover.sh
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
scripts/nm-dispatcher-failover.sh
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.gitignore at line 21, Remove the .gitignore entry that ignores
scripts/nm-dispatcher-failover.sh so the installer artifact is tracked;
specifically, update .gitignore to stop excluding nm-dispatcher-failover.sh (or
add an explicit negation) so install.sh can reliably read the source artifact,
ensuring the script is committed and available for packaging and releases.

4 changes: 0 additions & 4 deletions scripts/launch-browser.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ if ! wait_for_display "$DISPLAY" "${XAUTHORITY:-}"; then
exit 1
fi

# Reset profile on each start to avoid corruption from version changes
# (This is a CDP automation browser, not a persistent user browser)
rm -rf "$PROFILE"
mkdir -p "$PROFILE"

echo "Starting Chromium from $CHROMIUM on DISPLAY=$DISPLAY with CDP port $CDP_PORT"
Expand All @@ -107,7 +104,6 @@ exec env DISPLAY="$DISPLAY" HOME="$HOME" DBUS_SESSION_BUS_ADDRESS="disabled:" \
--no-default-browser-check \
--start-maximized \
--disable-gpu \
--no-sandbox \
--disable-dev-shm-usage \
--disable-background-networking \
--password-store=basic \
Expand Down
Loading