Skip to content

fix(browser): remove --no-sandbox and persist profile across restarts - #94

Merged
yalexx merged 2 commits into
betafrom
browser-fixes
Apr 21, 2026
Merged

yalexx merged 2 commits into
betafrom
browser-fixes

Conversation

@yalexx

@yalexx yalexx commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator
  • Drop --no-sandbox flag; kernel.unprivileged_userns_clone=1 on Jetson
    means the user-namespace sandbox works without it, and Chromium was
    showing a persistent "unsupported command-line flag" warning banner
  • Stop wiping the profile dir on every launch so cookies/logins/session
    state survive service restarts (UI already advertised this as a
    "persistent profile")

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com## Summary

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change
  • Documentation / tooling
  • Other: ___

How was this tested?

  • bun run lint passes
  • bun run test passes
  • bun run build succeeds
  • Manually verified on device / dev install

Checklist

  • Branch is up to date with main
  • Follows the conventions in CLAUDE.md and CONTRIBUTING.md
  • No secrets, tokens, or credentials committed
  • Added/updated tests where it makes sense
  • Updated docs where user-facing behavior changed

Screenshots / logs (if UI or runtime change)

Summary by CodeRabbit

  • Bug Fixes

    • Browser profile data is now retained between sessions
  • Chores

    • Updated version control configuration to ignore additional build-related scripts

yalexx and others added 2 commits April 21, 2026 09:17
- Drop --no-sandbox flag; kernel.unprivileged_userns_clone=1 on Jetson
  means the user-namespace sandbox works without it, and Chromium was
  showing a persistent "unsupported command-line flag" warning banner
- Stop wiping the profile dir on every launch so cookies/logins/session
  state survive service restarts (UI already advertised this as a
  "persistent profile")

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@yalexx
yalexx requested a review from a team as a code owner April 21, 2026 09:19
@coderabbitai

coderabbitai Bot commented Apr 21, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Modified browser launch script to preserve the Chromium profile directory between runs and removed the sandbox bypass flag, while also adding the nm-dispatcher-failover script to version control ignore list.

Changes

Cohort / File(s) Summary
Version Control Configuration
.gitignore
Added scripts/nm-dispatcher-failover.sh to ignored files.
Browser Launch Script
scripts/launch-browser.sh
Removed profile directory deletion logic (rm -rf) and the --no-sandbox Chromium flag; script now preserves profile state across runs using mkdir -p instead.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit hops through code so fine,
Profiles preserved, no more the mine,
Sandbox walls stay strong and true,
Fresh starts remembered, old paths renew! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description contains two bullet points explaining the rationale for changes and includes a co-author attribution, but lacks completion of required template sections including testing verification, checklist confirmation, and screenshots. Complete the description template by selecting the 'Bug fix' type, confirming testing steps (or marking N/A), checking applicable checklist items, and adding test output or verification evidence if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately summarizes the two main changes: removing the --no-sandbox flag and persisting the profile across restarts, matching the actual code modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch browser-fixes

Comment @coderabbitai help to get the list of available commands and usage tips.

@yalexx yalexx assigned yalexx and unassigned yalexx Apr 21, 2026
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

CI Summary

✅ Tests

  • Result: passed
  • View run
  • Coverage: statements 68.7%, branches 61.53%, functions 63.62%, lines 70.18%

✅ E2E

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.gitignore:
- Line 21: Remove the .gitignore entry that ignores
scripts/nm-dispatcher-failover.sh so the installer artifact is tracked;
specifically, update .gitignore to stop excluding nm-dispatcher-failover.sh (or
add an explicit negation) so install.sh can reliably read the source artifact,
ensuring the script is committed and available for packaging and releases.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 462acaf9-6ab5-4280-8606-94e72a70e746

📥 Commits

Reviewing files that changed from the base of the PR and between c2c0c4f and 3f021fa.

📒 Files selected for processing (2)
  • .gitignore
  • scripts/launch-browser.sh
💤 Files with no reviewable changes (1)
  • scripts/launch-browser.sh

Comment thread .gitignore
.omx/
playwright-report/
test-results/
scripts/nm-dispatcher-failover.sh

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Do not ignore a script required by installer packaging

Line 21 ignores scripts/nm-dispatcher-failover.sh, but install.sh consumes this file as a source artifact (install.sh:1-100). This can cause missing-file install failures if the script is not tracked in future commits/releases.

Suggested fix
-scripts/nm-dispatcher-failover.sh
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
scripts/nm-dispatcher-failover.sh
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.gitignore at line 21, Remove the .gitignore entry that ignores
scripts/nm-dispatcher-failover.sh so the installer artifact is tracked;
specifically, update .gitignore to stop excluding nm-dispatcher-failover.sh (or
add an explicit negation) so install.sh can reliably read the source artifact,
ensuring the script is committed and available for packaging and releases.

@yalexx
yalexx merged commit 220fdb1 into beta Apr 21, 2026
5 checks passed
@yalexx
yalexx deleted the browser-fixes branch April 21, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant