fix(browser): remove --no-sandbox and persist profile across restarts - #94
Conversation
- Drop --no-sandbox flag; kernel.unprivileged_userns_clone=1 on Jetson means the user-namespace sandbox works without it, and Chromium was showing a persistent "unsupported command-line flag" warning banner - Stop wiping the profile dir on every launch so cookies/logins/session state survive service restarts (UI already advertised this as a "persistent profile") Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughModified browser launch script to preserve the Chromium profile directory between runs and removed the sandbox bypass flag, while also adding the nm-dispatcher-failover script to version control ignore list. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.gitignore:
- Line 21: Remove the .gitignore entry that ignores
scripts/nm-dispatcher-failover.sh so the installer artifact is tracked;
specifically, update .gitignore to stop excluding nm-dispatcher-failover.sh (or
add an explicit negation) so install.sh can reliably read the source artifact,
ensuring the script is committed and available for packaging and releases.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 462acaf9-6ab5-4280-8606-94e72a70e746
📒 Files selected for processing (2)
.gitignorescripts/launch-browser.sh
💤 Files with no reviewable changes (1)
- scripts/launch-browser.sh
| .omx/ | ||
| playwright-report/ | ||
| test-results/ | ||
| scripts/nm-dispatcher-failover.sh |
There was a problem hiding this comment.
Do not ignore a script required by installer packaging
Line 21 ignores scripts/nm-dispatcher-failover.sh, but install.sh consumes this file as a source artifact (install.sh:1-100). This can cause missing-file install failures if the script is not tracked in future commits/releases.
Suggested fix
-scripts/nm-dispatcher-failover.sh📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| scripts/nm-dispatcher-failover.sh |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.gitignore at line 21, Remove the .gitignore entry that ignores
scripts/nm-dispatcher-failover.sh so the installer artifact is tracked;
specifically, update .gitignore to stop excluding nm-dispatcher-failover.sh (or
add an explicit negation) so install.sh can reliably read the source artifact,
ensuring the script is committed and available for packaging and releases.
means the user-namespace sandbox works without it, and Chromium was
showing a persistent "unsupported command-line flag" warning banner
state survive service restarts (UI already advertised this as a
"persistent profile")
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com## Summary
Type of change
How was this tested?
bun run lintpassesbun run testpassesbun run buildsucceedsChecklist
mainScreenshots / logs (if UI or runtime change)
Summary by CodeRabbit
Bug Fixes
Chores