The kfp setup.md file needs to tell you to run make setup command in the kind directory. #252
Conversation
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
kfp/doc/setup.md
Outdated
| @@ -66,10 +66,11 @@ choose your OS system, and process according to "(Optional) Install the MinIO Cl | |||
|
|
|||
| ## Installation steps <a name = "installation"></a> | |||
|
|
|||
| You can create a Kind cluster with all required software installed using the following command: | |||
| You can create a Kind cluster with all required software installed using the following command, run in the `kind` directory under the repo root: | |||
There was a problem hiding this comment.
Hi @deanwampler , sorry maybe it is my English, but the sentence is not clear to me especially that the first command is cd kind.
Will it be better:
You can create a Kind cluster with all required software installed using the following command:
make -C kind setupThere was a problem hiding this comment.
Maybe I missed that. Sorry.
There was a problem hiding this comment.
Pushing an update...
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
Signed-off-by: Dean Wampler <[email protected]>
|
I think the only "meaningful" difference left is the suggestion for an |
| @@ -27,6 +28,8 @@ include .make.defaults | |||
| # Global rules that are generally to be implemented in the sub-directories and can | |||
| # be overridden there (the double colon on the rule makes the overridable). | |||
|
|
|||
| all: clean test build | |||
There was a problem hiding this comment.
I don't know if we're ready for this, in particular build is ill-defined.
There was a problem hiding this comment.
The typo is fixed by #333.
The kind directory is going to be refactored in a separate PR, and the README file in the root directory will be updated accordingly.
|
@deanwampler , thank you for your review and the PR. We will update the instructions on how to install a Kind cluster. |
Note: This PR is based off my previous
deanw-pr. The only new change compared to that PR is to one file:kfp/doc/setup.md.Why are these changes needed?
Without telling you to run the
make setupcommand in thekinddirectory, you'll guess you should do it in thekfpdirectory, but the target isn't defined there.Related issue number (if any).
N/A