Skip to content

The kfp setup.md file needs to tell you to run make setup command in the kind directory. #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

The kfp setup.md file needs to tell you to run make setup command in the kind directory. #252

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a53265b
Added an all target.
deanwampler Jun 7, 2024
e8191f6
Adding missing dependencies.
deanwampler Jun 7, 2024
f4c88c9
Dean Wampler's friction logs.
deanwampler Jun 7, 2024
1763347
Fixed all ordering
deanwampler Jun 8, 2024
f385afc
Finished the V2 friction log
deanwampler Jun 8, 2024
f18d28d
Fixed all ordering
deanwampler Jun 8, 2024
cb1c202
Removed files I don't want in a PR back upstream.
deanwampler Jun 8, 2024
7a7cdec
Need to be in the correct directory before running make setup
deanwampler Jun 9, 2024
1222b44
Removed unneeded dependency
deanwampler Jun 18, 2024
c3d2272
Merge remote-tracking branch 'upstream/dev' into deanw-pr2
deanwampler Jun 18, 2024
be1cf4a
Removed unneeded dependency
deanwampler Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .make.defaults
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ help::
# It enables the processing of a common set of rules on all sub-projects underneath this directory.
# Currently, the common/standardized set of rules are as follows and supported by makefile.include
#
# all: clean setup test build
# clean:
# setup:
# build:
Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# sub-projects underneath this directory. Currently, the common/standardized set of rules are as follows
# and supported by .make.defaults
#
# all: clean setup test build
# setup:
# clean:
# build:
Expand All @@ -27,6 +28,8 @@ include .make.defaults
# Global rules that are generally to be implemented in the sub-directories and can
# be overridden there (the double colon on the rule makes the overridable).

all: clean test build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we're ready for this, in particular build is ill-defined.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daw3rd and @roytman If making a make all target is not feasible, please close this PR, but before doing that, Dean has found a typo in the setup.md file: deside => decide

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo is fixed by #333.

The kind directory is going to be refactored in a separate PR, and the README file in the root directory will be updated accordingly.


clean::
@# Help: Recursively $@ in all subdirs
$(MAKE) RULE=$@ .recurse
Expand Down
1 change: 1 addition & 0 deletions data-processing-lib/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies = [
"boto3==1.34.69",
"argparse",
"mmh3",
"moto>=5.0.9"
]

[build-system]
Expand Down
2 changes: 2 additions & 0 deletions data-processing-lib/ray/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ dependencies = [
# These two are to fix security issues identified by quay.io
"fastapi>=0.109.1",
"pillow>=10.2.0",
"bs4>=0.0.2",
"transformers>=4.41.2",
]

[build-system]
Expand Down
5 changes: 3 additions & 2 deletions kfp/doc/setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,11 @@ choose your OS system, and process according to "(Optional) Install the MinIO Cl

## Installation steps <a name = "installation"></a>

You can create a Kind cluster with all required software installed using the following command:
You can create a Kind cluster with all required software installed using the following command, run in the `kind` directory under the repo root:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deanwampler , sorry maybe it is my English, but the sentence is not clear to me especially that the first command is cd kind.
Will it be better:
You can create a Kind cluster with all required software installed using the following command:

make -C kind setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed that. Sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing an update...


```shell
make setup
cd kind # Assuming you are in the repo root directory.
make setup
```
from this main package directory or from the `kind` directory.
If you do not want to upload the testing data into the locally deployed Minio, and reduce memory footprint, please set:
Expand Down