fix(scripts) Fix publish script with wasmer-c-api
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l range. We use `VecDeque::drain` to read the captured stream, zipped with the given buffer. We could expect that only the yielded items from the `drain` will be removed, but actually no. Reading [the documentation](https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.drain): > Note 1: The element `range` is removed even if the iterator is not > consumed until the end. So by using a range like `..` will drain the entire captured stream, whatever we read from it. Said differently, if the given buffer length is smaller than the captured stream, the first read will drain the entire captured stream. This patch fixes the problem by specifying a better range: `..min(inner_buffer.len(), oc.buffer.len())`. With this new range, it's actually useless to increment `num_bytes_written`, we already know ahead of time the amount of bytes we are going to read. Consequently, the patch simplifies this code a little bit more.
… running `cargo publish`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on wasmerio#2053.
This patch is just 2 commits:
WASMER_PUBLISH_SCRIPT_IS_RUNNINGenv var when runningcargo publish,build.rswhen thescripts/publish.pyscript is running.Review