doc(c-api) Use the last README.md, not the deprecated one
#2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
MarkMcCaskey
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
In regards to the naming on Windows: I remember asking that same question > 6-12 months ago and getting an answer from Syrus but I have no idea what the answer was. I think there's an actual reason though
edit: if we find out again, we need to document it somewhere
|
cc @syrusakbary regarding my question in the first comment? bors r+ |
Hywan
added a commit
to Hywan/wasmer
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch updates the
README.mdused in theinclude/directory of the packaged C API. We must use the lastlib/c-api/README.mdrather than thelib/c-api/doc/deprecated/index.mdfile. That's a mistake.Also, I wonder why
wasmer_c_api.{dll|lib)on Windows isn't renamed towasmer.{dll|lib}as we do for ther other platforms?Review