Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'Add manual task' feature #4065

Closed
wants to merge 34 commits into from
Closed

Implement 'Add manual task' feature #4065

wants to merge 34 commits into from

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Jul 21, 2024 •
edited
Loading

Fixes #3872
It creates a task for a user via communication, if a comment is assigned to a user(staff). If assigned_to is empty then it will just be a comment, same like before.

Comment form:
image

Comment listing:
image

Task list:
image

Test Steps

  • …

@sandeepsajan0 sandeepsajan0 changed the base branch from main to enhancement/remove-tasks July 29, 2024 13:26
@sandeepsajan0 sandeepsajan0 changed the title [WIP]: Implementing Add task feature Implement 'Add manual task' feature Jul 30, 2024
@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review July 30, 2024 12:20
@sandeepsajan0
Copy link
Member Author

@frjo @theskumar @wes-otf Is it looking good?

image

@frjo
Copy link
Contributor

frjo commented Aug 7, 2024

@sandeepsajan0 Looks really good!

@sandeepsajan0
Copy link
Member Author

The listing is also updated like this. "Assigned as task to" => "Assigned to"
image

@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Patch Mini change, used in release drafter labels Aug 8, 2024
@frjo
Copy link
Contributor

frjo commented Aug 8, 2024

@sandeepsajan0 This can now be rebased on top of main.

sandeepsajan0 and others added 17 commits August 10, 2024 12:47
@sandeepsajan0
Remove assigned task
1aceeac
@sandeepsajan0
Added migration
52ea82a
@sandeepsajan0
Replace confirm dialog box by hx-confirm
7d5f9d1
@sandeepsajan0
Remove dialog package
f01b744
@sandeepsajan0
Remove tasks form task lists without reloading the page
2039e33
@sandeepsajan0
Resolve migrations conflicts
a8824e0
@sandeepsajan0
Show trash icon on hover and remove it for user group tasks
f947a84
@sandeepsajan0
Use Dialog box inplace of fancybox modal, with htmx and alpine(only f…
64dd5c1 
…or lead update yet)
@sandeepsajan0
Use htmx and dialog for project creation
248dc80
@sandeepsajan0
Use htmx and dialog for create reminder form
2f226a0
@sandeepsajan0
Use htmx and dialog for submission progress/status update
67bc904
@sandeepsajan0
Fix requirements and progress button code
2d94490
@sandeepsajan0
Use htmx and dialog box for meta terms
ba175cb
@sandeepsajan0
Remove Select2Widget for reviewers and partners, add defer to alpine …
1b11c74 
…dialog
@sandeepsajan0
Use dialog modal for all other dialogs to avoid UI shift and closing …
9f8f0bf 
…issue
@theskumar @sandeepsajan0
Add @fylgja/alpinejs-dialog as npm package
d663244
@theskumar @sandeepsajan0
New dialog implementation
0c20039
@sandeepsajan0 sandeepsajan0 changed the base branch from enhancement/remove-tasks to main August 10, 2024 12:44
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team labels Aug 10, 2024
@sandeepsajan0
Copy link
Member Author

@frjo @theskumar @wes-otf Does it look better? Instead of having label and input in the same line now it is the same as visibility.
image

@sandeepsajan0
Copy link
Member Author

@frjo The latest Ui is also ready for testing.

@frjo
Copy link
Contributor

frjo commented Aug 22, 2024

Deployed to test.

theskumar
theskumar reviewed Aug 26, 2024
View reviewed changes
hypha/apply/todo/models.py
@@ -28,6 +28,8 @@ class Task(models.Model):
)
related_object_id = models.PositiveIntegerField(blank=True, null=True)
related_object = GenericForeignKey("related_content_type", "related_object_id")
# for manually added tasks
message = models.CharField(max_length=250, null=True, blank=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull the message from the related item (i.e. the comment/activity object) itself? Maybe I'm missing something but it would better not to de-duplicate the message, as they can be edited.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think comment edited case should be handled but a separate task message can provide us flexibility in changing the language of the task message, it might be helpful later or in another kind of tasks. And duplicity in terms of storage shouldn't be an issue as these tasks are temporary and will be removed regularly.

@frjo frjo removed Status: Needs testing Tickets that need testing/qa Status: Needs user testing 👷 Tasks that should be tested by OTF's user test team labels Sep 9, 2024
@frjo
Copy link
Contributor

frjo commented Sep 10, 2024

This PR will be merged in to #3932 since that PR redesigns the communication tab.

@frjo frjo marked this pull request as draft September 12, 2024 06:07
@frjo frjo added Status: RTBC Internal Dev use only and removed Status: Tested - approved for live ✅ labels Sep 12, 2024
@theskumar
Copy link
Member

closing in favor of #3932 . This will be included in that PR

@theskumar theskumar closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theskumar theskumar theskumar left review comments

@wes-otf wes-otf wes-otf approved these changes

@frjo frjo frjo approved these changes

Assignees
No one assigned
Labels
Status: RTBC Internal Dev use only Type: Feature This is something new (not an enhancement of an existing thing). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a "Add task" feature
4 participants
@sandeepsajan0 @frjo @theskumar @wes-otf