Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild communication and activity feed #3932

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rebuild communication and activity feed #3932

wants to merge 2 commits into from

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented May 20, 2024

  • Introduce machine generated avatars based on the user's name (in-future allow for gravatar or similar service)
  • Color Code the user avatar based on their roles 🆕
  • Render the staff roles as label (Show user group after names as a label #3916)
  • Reduce the size of the rendered comment box.
  • Merge activities with communication in a single timeline. 🆕
  • Use htmx for comment edit function, the js version seems to break some functionality.
  • Use different icons for different activities where possible.
  • Render paginated comment and activities 🆕
  • Cleanup/remove JSON APIs related to comments
  • Use the same logic for rendering of comments on the projects module
  • Async comment add (won't be done in this PR)
  • fix testcases

Work in progress screenshots

Screenshot 2024-08-26 at 12  07 12@2x

Test Steps

  • Checkout the activity feed and communication

@theskumar theskumar self-assigned this May 20, 2024
@theskumar theskumar changed the title Add user avatars to communication + merge activity in comms UI Upgrades to communications Tab (User Avatars, Merge activities, ...) May 20, 2024
@wes-otf
Copy link
Contributor

wes-otf commented May 23, 2024

@theskumar @frjo I presented this today to the program team and everyone really liked the idea of combining the comments & activities tab - feedback I got was that folks sometimes found it inconvenient to flip back & forth between tabs trying to figure out when different events happened and correlating that to the comments.

@wes-otf
Copy link
Contributor

wes-otf commented May 23, 2024

also received some enthusiasm around avatars!

@theskumar
Copy link
Member Author

theskumar commented Aug 12, 2024

Glad to hear! I'm resuming work on it and keep you posted.

@theskumar theskumar force-pushed the user-avatars branch 7 times, most recently from 23ef830 to 0184369 Compare August 17, 2024 04:26
@theskumar theskumar force-pushed the user-avatars branch 5 times, most recently from eec6ead to e099ad2 Compare August 26, 2024 06:18
@theskumar theskumar changed the title UI Upgrades to communications Tab (User Avatars, Merge activities, ...) Rebuild communication and activity feed Aug 26, 2024
@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Aug 26, 2024
@theskumar theskumar force-pushed the user-avatars branch 5 times, most recently from fd623a8 to a5ba323 Compare August 26, 2024 10:53
@theskumar
Copy link
Member Author

This should too good to review for UX/UI

Pending items.

  • Update test cases
  • make the comment submission async, without page refresh.

@theskumar theskumar force-pushed the user-avatars branch 6 times, most recently from 3c98f74 to a67fcf7 Compare August 27, 2024 04:58
@frjo frjo mentioned this pull request Sep 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants