-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Mecab not set #182
[BUG] Mecab not set #182
Conversation
This reverts commit 9f54870.
Fixes many small parts of the code not collaborating with each other.
Hi, I looked at your changes and they were valid but they implied many changes in function signatures. I was also not satisfied with my own previous code relying on global JS variables, as they is always a point where they become messy. So I changed the signature of The supplementary overhead is contained as well: ~500 B and 50ms on average. It supports caching as well, so it won't be concerning. |
@HugoFara
From #155,
The bug still exists in c2cb13b. I changed the PR to accommodate the #153. Test or @ProgramComputer for me to test before closing.
Lang_id allows setting mecab independent from language.
Reproduce:
Install LWT.
Do not install mecab and don't set "mecab" in regex setting.
Open a Japanese text.