Reintroduce whitespace control parsing fix with legacy override #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
approved these changes
Jul 28, 2022
src/main/java/com/hubspot/jinjava/tree/parse/StrictWhitespaceControlParser.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hubspot/jinjava/tree/parse/StrictWhitespaceControlParser.java
Outdated
Show resolved
Hide resolved
tkindy
force-pushed
the
tk/reintro-whitespace-fix
branch
from
f5c3d5b to
6a348de
Compare
tkindy
force-pushed
the
tk/reintro-whitespace-fix
branch
from
6a348de to
009149a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #892
Depends on #902
This PR is basically #896 but with the changes disabled by default. They can be enabled by setting a new flag on
LegacyOverridesas part of theJinjavaConfig.