Parse leading negatives #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
approved these changes
Jul 21, 2022
tkindy
force-pushed
the
tk/whitespace-control-negative-bug
branch
from
7dfe3c6 to
bacaad5
Compare
tkindy
force-pushed
the
tk/whitespace-control-negative-bug
branch
from
bacaad5 to
0c9d70b
Compare
This was referenced Jul 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #892
Depends on #895
Currently, the expression
{{ -10 }}is interpreted by Jinjava as10with leading whitespace removed when it should be interpreted as-10. The problem is that Jinjava interprets the unary minus as a whitespace control character because the parser is lenient about whitespace between the tag and the dash.This PR adjusts the whitespace control character parsing to require no space between the tag and the control character. This aligns with Jinja's behavior: