Fix build #72
Merged
Fix build #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbeaudreault
added a commit
that referenced
this pull request
May 13, 2024
bbeaudreault
added a commit
that referenced
this pull request
May 13, 2024
ndimiduk
pushed a commit
that referenced
this pull request
Sep 23, 2024
charlesconnell
pushed a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to start using MAVEN_BUILD_ARGS.
Also, I was wrong @charlesconnell, you were right to include the version for compression-zstd. It used to be that it wasn't necessary, but in the recent build refactors I changed the bundles so they no longer inherit from the hbase parent pom. This was done to insulate us from some profile nonsense in the hbase pom, but has the side-effect that we no longer inherit the versions for modules we pull in.