Skip to content

Conversation

@bbeaudreault
Copy link
Member

The crux of the changes here:

  • Remove the per-module .blazar.yaml and copy_blazar_yaml.sh script
  • Use single-module buildpack for the main hbase build
  • Move the hbase-rpm build into its own build instead of hiding within hbase-assembly. This was done for transparency as well as build speed, since with the single module build the rpm would extend the main hbase build time. We can now build hbase-rpm in parallel with the bundles. Note that the hbase-rpm still uses the output of hbase-assembly, but just downloads the tar from nexus.
  • Disconnect our bundle modules from the main hbase modules so we don't need to deal with weird build profile issues. "Simplify" the poms for these a little (they are still complicated)
  • Re-enable the flatten plugin in hbase. I had disabled this when we were on hadoop2, but now can be re-enabled.

I tested this with a downstreamer project. I pulled the bundles into a project and ran mvn dependency:tree with and without these changes. I collected the output and turned it into somethign that could be diffed. I iterated on the exclusions until things matched. I also diffed the output of jar -tf on the actual shaded jars. All looks good.

@bbeaudreault bbeaudreault merged commit 366263b into hubspot-2.5 Jan 17, 2024
@bbeaudreault bbeaudreault deleted the delegating branch January 17, 2024 22:56
bbeaudreault added a commit that referenced this pull request May 13, 2024
- Fix build (#72)
- pre-set MAVEN_ARGS as the buildpack requires (#68)
- Redo build as a single module maven build, with separate hbase-rpm and bundle handling (#66)
- Build into AnyLinuxVersion repos for future-proofing (#87)
bbeaudreault added a commit that referenced this pull request May 13, 2024
- Fix build (#72)
- pre-set MAVEN_ARGS as the buildpack requires (#68)
- Redo build as a single module maven build, with separate hbase-rpm and bundle handling (#66)
- Build into AnyLinuxVersion repos for future-proofing (#87)
ndimiduk pushed a commit that referenced this pull request Sep 23, 2024
- Fix build (#72)
- pre-set MAVEN_ARGS as the buildpack requires (#68)
- Redo build as a single module maven build, with separate hbase-rpm and bundle handling (#66)
- Build into AnyLinuxVersion repos for future-proofing (#87)
charlesconnell pushed a commit that referenced this pull request Dec 20, 2024
- Fix build (#72)
- pre-set MAVEN_ARGS as the buildpack requires (#68)
- Redo build as a single module maven build, with separate hbase-rpm and bundle handling (#66)
- Build into AnyLinuxVersion repos for future-proofing (#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants