Move modal alert to inline #958
Conversation
There was a problem hiding this comment.
@melissahie thanks for the PR! There is a small code formatting issue mentioned below that needs to be addressed. Ideally I would like to see this added to the edit-panel component. That way it can be used on all edit screens instead of just patient.
| })); | ||
| $('.message').show(); | ||
| $('.message').text(this.get('i18n').t('patients.messages.savedPatient', record)); | ||
| $(".message").delay(3000).fadeOut(100); |
There was a problem hiding this comment.
This line is erroring out in our tests because it should use single quotes instead of double quotes.
|
@jkleinsc Can I help you add inline alert to the edit-panel component and fix this travis error? |
|
@dasManaswini this is @melissahie's PR so as far as fixing the Travis error, that would need to be done from @melissahie's fork and branch here: https://github.com/melissahie/hospitalrun-frontend/tree/enhancement/move_modal_to_inline, so you would need to fork that repo, fix the error and submit your own PR. In regards to adding this to the edit-panel component, I would create a fork off of this repo (https://github.com/HospitalRun/hospitalrun-frontend) and modify https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/components/edit-panel.js and https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/templates/components/edit-panel.hbs to temporarily display the markup when a value is set on the edit-panel component. Hope that helps. Let me know if you have further questions. |
|
I am still working on this edit- panel component. Please add a Work in progress label |
Fixes #377
Changes proposed in this pull request:
@billybonks @jglovier