Show patient update confirmation as inline alert rather than modal

[jglovier]

Current experience: When you update a patient record, you are shown a confirmation dialog as a modal that lets you go back, or simply close the dialog. It is superfluous and requires an extra click to keep working if you don't want to return to the patient record screen.

Better experience: Instead, we should render the alert inline just above the button so that you don't have the extra step of dismissing the modal if you want to do anything other than returning to the patient index. We can still include the patient index link in the confirmation alert for convenience if that is your next destination.

Steps to reproduce: Go to a patient record and update any piece of information.

[dswanson]

I propose this would be an improvement for the user experience. I would encourage most of the modal confirmation dialogs be "retired". Nice!

[jglovier]

I would encourage most of the modal confirmation dialogs be "retired".

+:100:

[eddiesholl]

There's a couple of options I evaluated recently for ember notifications. We went with:
http://stonecircle.github.io/ember-cli-notifications/

Another nice option is:
http://simonwade.me/assets/ember-demos/#/ember-notify

[jkleinsc]

@eddiesholl thanks for the suggestions. I really like ember-cli-notifications. @jglovier what do you think?

[jglovier]

I'm not really interested in any of the default styling or animations of those options, but anything that solves the basic case of showing an inline alert without a modal is fine with me.

The placement of the alert should be in close proximity to the button where the alert was generated from, or at the top of the page if it is generated as part of a general page load condition. I'll create some design mocks to show what I think we want visually.

[jkleinsc]

@jglovier perfect 👍

[clettenberg]

I can take this one if no one else is working on it. I have a very rough wip using ember-cli-notifications
Edit: Nevermind. I just re-read the thread and had missed the part about mocking this up first.

[amyrlam]

I'll work on this

[jscottchapman]

@amyrlam It looks like you are working on this one. Is that right? Just wanted to make sure two people aren't working on the same issue unknowingly.

[amyrlam]

@jscottchapman hi! I have a branch https://github.com/amyrlam/hospitalrun-frontend/tree/amyrlam/no-modal, but since I have another issue in work, feel free to give to someone else. You could run my branch locally to see a demo. @jglovier mentioned moving the notification above the button (right now it's at the top center of the page)

[ivanlori]

@tangollama , Hi I am new on this project, I would like to work on this issue, can I?

[jkleinsc]

@ivanlori it is yours to work on.

[jglovier]

@ivanlori any update on this? If you've not had a chance to work on it, and don't think you will in the immediate future, I'd like to add the help-wanted label back on it.

[ivanlori]

Hi Joel, yes, it would be better with help-wanted label 2017-01-17 15:22 GMT+01:00 Joel Glovier <[email protected]>:

…

@ivanlori <https://github.com/ivanlori> any update on this? If you've not had a chance to work on it, and don't think you will in the immediate future, I'd like to add the help-wanted label back on it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#377 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHRJOKePsli8MfsLVTltWKnl3s9-1CA2ks5rTM6tgaJpZM4H0HQe> .

[melissahie]

taking this issue