This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Replace jshint with eslint. Closes #596 and closes #601. #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unreacheable code, unused variable and use of `console`
|
Note that |
|
@btecu we don't need to support node 0.10 and 0.12, so I would recommend using the latest ember-cli-eslint |
Node 0.10 and 0.12 are not supported
|
@jkleinsc Great, I've updated |
21 tasks
jkleinsc
suggested changes
Oct 13, 2016
| @@ -73,6 +73,7 @@ | |||
| "ember-suave": "4.0.1", | |||
There was a problem hiding this comment.
Shouldn't ember-suave be removed?
jkleinsc
approved these changes
Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jshinthas merged witheslintand onlyeslintwill be supported.Note: Using
ember-cli-eslintversion2.0.0because the latest3.0.0has dropped support for node0.10and0.12.Will follow additional PR to fix some newly discovered warnings.
cc @HospitalRun/core-maintainers