Cleanup based on ember-suave rules

[btecu]

Continuation of #724.

Plan
Currently, all failing rules are turned off.
The plan is to go and fix all of the errors that the core maintainers agree on and submit those in individual (smaller) pull requests for faster merging and to avoid conflicts.

Changes proposed

• array-bracket-spacing: [ 1, 2 ] -> [1, 2] [Cleanup] eslint array-bracket-spacing #733
• camelcase: some_ember_function -> someEmberFunction
• comma-spacing: thing(a,b) -> thing(a, b) [Cleanup] eslint comma-spacing #734
• ember-suave/no-const-outside-module-scope: const -> let (inside modules) [Cleanup] eslint ember-suave/no-const-outside-module-scope #735
• ember-suave/no-direct-property-access: Ember.isNone() -> const { isNone } = Ember; isNone() @amyrlam working on it
• ember-suave/prefer-destructuring: let brand = car.brand; -> let { brand } = car; [CLEANUP] eslint ember-suave/prefer-destructuring #769
• ember-suave/require-access-in-comments: most likely n/a
• indent: consistent indentation (2 spaces) [CLEANUP] eslint indent #772
• key-spacing: { age:21 } -> { age: 21 } [Cleanup] eslint key-spacing #741
• keyword-spacing: }else { -> } else { [CLEANUP] eslint keyword-spacing #771
• new-cap: new report() -> new Report() [Cleanup] eslint new-cap #810
• no-console: don't console log - questionable
• object-curly-spacing: {'foo': 'bar'} -> { 'foo': 'bar' } [CLEANUP] eslint object-curly-spacing #770
• object-shorthand: doWork: function() -> doWork() [Cleanup] eslint prefer-shorthand #809
• one-var: let a, b; -> let a; let b; [Cleanup] eslint one-var #736
• operator-linebreak: + should be on the new line instead of end of previous line [CLEANUP] eslint operator-linebreak #773
• prefer-spread: obj.foo.apply(obj, args) -> foo.apply(obj, args) [Cleanup] eslint prefer-spread #808
• prefer-template 'My name is ' + name -> My name is ${name} [Cleanup] eslint prefer-template #745
• quotes: " -> ' [Cleanup] eslint quotes #746
• spaced-comment -> //Comment -> // Comment[Cleanup] eslint spaced-comment #739
• space-infix-ops: a+b -> a + b [Cleanup] eslint space-infix-ops #740

Will leave no-console off.

cc @HospitalRun/core-maintainers

[jkleinsc]

Thanks @btecu!

[amyrlam]

Hi, I'll take this one for now if that's ok?

ember-suave/no-direct-property-access: Ember.isNone() -> const { isNone } = Ember; isNone()

aka remove "disallowDirectPropertyAccess": null, EDIT: or start with "disallowDirectPropertyAccess": ["Ember"]

[btecu]

@amyrlam Yes, go for it. 😄

[amyrlam]

@btecu cool thanks, started a branch

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.