Translations

[billybonks]

OK so this is quite a few translation changes :)

• Refactored visits, to look a bit like the rest.
• translated components, parrtials, print.invoice
• fixed a few bugs

i have a note saying i must go through invoices aswell, would like to discuss my 2 refactor issues first.

• Page Titles #551
• Refactor translations file to match model setup #547

[jkleinsc]

@billybonks -- one thing I realized is that invoices has some hospital specific information in it. Specifically these labels:

• print: {
• invoice: {

•  hospital_name: 'TEBOW CURE HOSPITAL',
  

•  hospital_address: 'J.P. Laurel Ave. corner Banawe St. Brgy Aquino Davao City, Philippines',
  

•  hospital_contact: 'Telephone: (082) 300-5345    Email: [email protected]',
  

•  hospital_footer: 'Certified Correct by: Leron L. Lehman- Executive Director',
  

I don't think we should add them to the translations file and I am thinking for now maybe we just completely remove this text from the input.
Ideally this text is setup by an admin #419 was supposed to do this, but it never got completed.

Invoicing needs more work in general, so I don't want to spend a lot of time working around this, particularly if we are going to refactor, so I am recommending we simply remove those fields from the print template and/or throw some generic text in for now.

Additionally, "billing.labels.phil_health" should be changed to a generic label, National Insurance

[billybonks]

@jkleinsc Updated based on your comments 👍 for now i removed all invoice changes will open a new pr for them

[jkleinsc]

@billybonks Does that mean this PR is ready to go?

[billybonks]

ye if you are happy with the code.

On Thu, Jul 7, 2016 at 5:26 PM John Kleinschmidt [email protected]
wrote:

@billybonks https://github.com/billybonks Does that mean this PR is
ready to go?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#536 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABkGyPgsQiiWkxU-50q6KCEg2QJyDavOks5qTRqcgaJpZM4I-nCJ
.

[jkleinsc]

Looks good to me. I'll merge.