This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Code for updating invoice headers and footers #419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taras here's the PR for the invoice header work. |
|
|
||
| model: function() { | ||
| return new Ember.RSVP.Promise(function(resolve) { | ||
| this.get('store').find('option', 'invoice_template').then(function(invoiceOptions) { |
There was a problem hiding this comment.
can you use the es6 => for keeping the correct this scope
|
@billybonks this PR needs some UI/UX attention. We should pull @jglovier in to look at this and then we can start doing clean up. Adding |
Merged
|
Can someone please post some screenshots of the UI changes in this PR? |
|
This PR is for issue #370 |
ScreenshotsHere is what the new screens look like at the moment. We need to make them clearer. Administration -> Invoice Template -> Edit
Administration -> Invoice Template -> Preview
TODO
/cc @jglovier |
|
@taras thanks for picking this back up and updating this PR! Looking forward to having Chris and Lennex contributing! |
|
Closing b/c this is covered by other features. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
Adding functionality to administration section to allow users to update invoice headers and footers.
cc @HospitalRun/core-maintainers