feat(incidents): add ability to resolve incidents

[blestab]

Fixes #2078.
Fixes #2218.

Changes proposed in this pull request:

Incident View

• Add new user permission CompleteIncident
• Add new incident property CompletedOn
• Add new incident status completed
• Add Complete Incident button on ViewIncident screen
• Add Completed On display information on the ViewIncident screen for a resolved incident
• Display Reported By username correctly
• Unit Tests
  -- Show Complete Incident button when incident is not completed
  -- Show Complete Incident button when user has the access
  -- Do not show the Complete button when incident is already completed
  -- Do not show the Complete button if user does not have the access
  -- Show the Completed On details if the incident is completed
  -- Do not show the Completed On details if the incident is not completed
  -- Extract username utility unit test

Incidents View

• Display Reported By username correctly
• Add completed status to list of filter options

Incidents Utilities

• Utility to extract username from the couchdb user id string

[gitpod-io]

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/7jw83ca31
✅ Preview: https://hospitalrun-frontend-git-fork-blestab-master.hospitalrun.vercel.app

[blestab]

@jackcmeyer @kumikokashii @tehkapa sorry to bug, may i have some guidance/suggestions regarding items [Q1] and [Q2] in my draft PR.

[fox1t]

As for Q1 you are trying to modify in place an object that is not extensible
try to write it like

  const completedIncident = await IncidentRepository.saveOrUpdate({
    ...incidentToComplete,
    completedOn: new Date(Date.now().valueOf()).toISOString(),
    status: 'completed',
  })

You cannot modify objects in place: you have to "generate" a new object and copy props from the old one.

Q2 seems that it need a fix. You can open an another PR if you want to work on it :)

[blestab]

Thanks @fox1t i could have sworn that i tried this before and it refused to work 😇 , works this time around though so that one is now fixed, thanks.

I have also fixed Q2 as part of this PR so will update the description.

Just need to add some tests then i can remove it from draft status

[blestab]

Hi all,
PR is now ready for review

[jackcmeyer]

few code related comments.

overall, everything looks good.

One thing, I think we should rename everything that says complete to be resolve. It seems like resolve would be the event a user would take when a incident is no longer an incident.

[blestab]

Thanks @jackcmeyer
I have made code changes as suggested.