Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add ability to resolve an incident #2078

Closed
jackcmeyer opened this issue May 16, 2020 · 7 comments · Fixed by #2222
Closed

Add ability to resolve an incident #2078

jackcmeyer opened this issue May 16, 2020 · 7 comments · Fixed by #2222
Assignees
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions incidents LOE - medium indicates that the level of effort to complete issue is medium
Milestone

Comments

@jackcmeyer
Copy link
Member

Scenario

AS
A user who has the ability to resolve an incident

I WANT
A button that I can click that sets the incident's status to resolved

SO THAT
I can determine when an incident is no longer needed to be opened.

Acceptance Criteria

GIVEN
A user who has the ability to resolve an incident and an incident that is in the reported status

WHEN
I navigate to the incident that is in the reported status

THEN
I should see a required text field and a button at the bottom of the page that says Resolve.

GIVEN
The incident

WHEN
I click on the resolve button

THEN
The incident's status should be set as resolved and the resolvedOn date should be set to the current time.

GIVEN
The incident

WHEN
I click on the resolve button

THEN
The incident's status should be set as resolved and the resolvedOn date should be set to the current time.

GIVEN
The incident

WHEN
I click on the resolve button and there is no content in the Resolution text field

THEN
An error message should appear stating that the incident could not be resolved and the Resolution field should have feedback stating that it is required.

Technical Notes

  • New, required, text field called resolution should be displayed when viewing an incident
  • New permission ResolveIncident should be added
  • New redux thunk named resolveIncident
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun May 16, 2020
@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions incidents LOE - medium indicates that the level of effort to complete issue is medium 🚀enhancement an issue/pull request that adds a feature to the application labels May 16, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone May 16, 2020
@christiantgolden
Copy link

I'd like to give this one a shot as a first time contributor.

@jackcmeyer
Copy link
Member Author

I'd like to give this one a shot as a first time contributor.

Sounds great!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels May 22, 2020
@christiantgolden
Copy link

christiantgolden commented Jun 9, 2020

I'm running into an issue trying to set incident properties. I receive an error that an incident's properties are read only. I've modeled my code largely off of ReportIncident related code, but is initially called from within ViewIncident. I know this isn't much to go on just yet, but before I seek more detailed assistance, and provide more in depth info, does anything come to mind off the top of your head that I might be overlooking when it comes to read/write access to object properties? @jackcmeyer

@jackcmeyer
Copy link
Member Author

The reason that you are getting that error is you are likely directly modifying a redux object, which are immutable.

Feel free to open a draft PR an I can review the code and better help debug.

@christiantgolden
Copy link

Oh wow. I didn't know draft PRs were a thing! Thanks for offering to review. I'll submit a draft PR soon.

@nischayv
Copy link
Contributor

Is this still being worked on, otherwise I don't mind taking a shot at it?

@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions and removed in progress indicates that issue/pull request is currently being worked on labels Jun 27, 2020
@blestab
Copy link
Contributor

blestab commented Jul 8, 2020

Hi @jackcmeyer
I see this is back to needing an assignee? You can put it on my name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions incidents LOE - medium indicates that the level of effort to complete issue is medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants