Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(navbar): add icons to 'quick add' icon in navbar #2220

Merged
merged 2 commits into from
Jul 9, 2020
Merged

feat(navbar): add icons to 'quick add' icon in navbar #2220

merged 2 commits into from
Jul 9, 2020

Conversation

AlexTan331
Copy link
Contributor

@AlexTan331 AlexTan331 commented Jul 9, 2020 •
edited by matteovivona
Loading

fix #2208

Changes proposed in this pull request:

  • add type check for icons
  • add icon properties in page object
  • add icon to each item in 'quick add' navbar item

No new dependency added

@jsf-clabot
Copy link

jsf-clabot commented Jul 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Jul 9, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Jul 9, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/20dseytjv
✅ Preview: https://hospitalrun-frontend-git-fork-alextan331-quick-add-list-icon.hospitalrun.vercel.app

@matteovivona matteovivona added in progress indicates that issue/pull request is currently being worked on 🚀enhancement an issue/pull request that adds a feature to the application labels Jul 9, 2020
@matteovivona matteovivona added this to the v2.0 milestone Jul 9, 2020
@matteovivona matteovivona requested review from jackcmeyer and a team July 9, 2020 15:07
@AlexTan331 AlexTan331 changed the title feat(navbar component): add icons to 'quick add' icon in navbar WIP: feat(navbar component): add icons to 'quick add' icon in navbar Jul 9, 2020
@AlexTan331 AlexTan331 changed the title WIP: feat(navbar component): add icons to 'quick add' icon in navbar feat(navbar component): add icons to 'quick add' icon in navbar Jul 9, 2020
@jackcmeyer jackcmeyer changed the title feat(navbar component): add icons to 'quick add' icon in navbar feat(navbar): add icons to 'quick add' icon in navbar Jul 9, 2020
@jackcmeyer jackcmeyer merged commit 7e0aba7 into HospitalRun:master Jul 9, 2020
@linus345 linus345 mentioned this pull request Jul 10, 2020
Closed
@jackcmeyer jackcmeyer linked an issue Jul 11, 2020 that may be closed by this pull request
Add icons to hamburger menu #2209
Closed
@jackcmeyer jackcmeyer mentioned this pull request Jul 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer approved these changes

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add icons to hamburger menu Add Icons to 'quick add' icon in Navbar
4 participants
@AlexTan331 @jsf-clabot @jackcmeyer @matteovivona