feat(menu): added icons to items in the hamburger menu #2213
Conversation
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/nth9uuy0j |
| }, | ||
| viewIncidents: { | ||
| permission: Permissions.ViewIncidents, | ||
| label: 'incidents.reports.label', | ||
| path: '/incidents', | ||
| icon: 'incident', | ||
| }, | ||
| settings: { | ||
| permission: null, |
There was a problem hiding this comment.
we have a settings icon that we can use here.
There was a problem hiding this comment.
Instead of incident for viewIncidents(the marked line) or for the settings field? I assume the settings field?
Do you know the name of the icon?
There was a problem hiding this comment.
For the settings field, sorry the marked line got a little weird.
The name of the icon is called setting.
For future reference, here are a list of our icon set: https://components.hospitalrun.io/?path=/story/icons--icon-set
matteovivona
added
the
in progress
|
Should this pr be closed? Looks like #2220 did almost the exact same. |
Closes #2209
Changes proposed in this pull request:
note
useTranslatorseems to have been automatically fixed by the linter and was included in the commit. Let me know if this is a problem.