Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(patient): put "Unknow" next to date of brith field #2217

Merged
merged 8 commits into from
Jul 11, 2020

Conversation

Hrugved
Copy link
Contributor

@Hrugved Hrugved commented Jul 9, 2020

Slight UI change while creating new patient

Fixes #2216.

Changes proposed in this pull request:

  • put checkbox underneath the "Date of birth" field in panel for creating new patient

Screenshot 2020-07-09 at 11 49 19 AM

@gitpod-io
Copy link

gitpod-io bot commented Jul 9, 2020

@matteovivona matteovivona requested review from jackcmeyer and a user July 9, 2020 06:42
@matteovivona matteovivona added this to the v2.0 milestone Jul 9, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jul 9, 2020
@vercel
Copy link

vercel bot commented Jul 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/2glgelkk7
✅ Preview: https://hospitalrun-frontend-git-fork-hrugved-2216.hospitalrun.vercel.app

@jackcmeyer jackcmeyer changed the title feat(ui change in src/patients/generalinformation.tsx): put "Unknown"… feat(patient): put "Unknown"… Jul 9, 2020
@jackcmeyer jackcmeyer changed the title feat(patient): put "Unknown"… feat(patient): put "Unknow" next to date of brith field Jul 9, 2020
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works as expected, however, I think that maybe we should move date of birth, occupation, and preferred language all on one line.

@jackcmeyer jackcmeyer self-requested a review July 9, 2020 23:59
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works as expected, however, I think that maybe we should move date of birth, occupation, and preferred language all on one line.

@fox1t
Copy link
Member

fox1t commented Jul 10, 2020

@jackcmeyer i agree!

@jackcmeyer jackcmeyer added the patients issue/pull request that interacts with patients module label Jul 11, 2020
@jackcmeyer jackcmeyer merged commit ce16424 into HospitalRun:master Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update patient form (general information) UX
4 participants