Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

update patient form (general information) UX #2216

Closed
vault-developer opened this issue Jul 6, 2020 · 5 comments · Fixed by #2217
Closed

update patient form (general information) UX #2216

vault-developer opened this issue Jul 6, 2020 · 5 comments · Fixed by #2217
Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module
Milestone

Comments

@vault-developer
Copy link
Contributor

🚀 Feature Proposal

Update general information form UX

  1. Put "Unknown" checkbox under "Date of Birth" field.

Motivation

Now we have input "Date of birth" and checkbox "Unknown"

  1. It's not clear, that checkbox "unknown" is related to field "Date of birth". User can suggest, that this checkbox is for "Patient type", because it's under this field.
  2. If "Unknown" is checked, "Date of Birth" field is hidden. If someone will view such patient, there is no way to find out, what field does "Unknown" belong to.

image

P.S. I can work on this issue if you don't mind

@matteovivona
Copy link
Contributor

The date of birth isn't a mandatory field, so if you don't enter it, it is in fact already "Unknown".
@lauggh @jackcmeyer @fox1t opinions? does this new checkbox come in useful?

@lauggh
Copy link
Member

lauggh commented Jul 6, 2020

Yes. I agree with the proposal here. While not required, it is useful as a checklist of questions during data entry or registration

@fox1t
Copy link
Member

fox1t commented Jul 6, 2020

I agree too with the proposal. Actually this makes DOB mandatory. So let’s add also it to this proposal.

@blestab
Copy link
Contributor

blestab commented Jul 6, 2020

Do not hide "Date of Birth" field if "Unknown" is checked, only disable it.

I am not sure about this proposal as checking "Unknown" shows the Approximate Age (at least in staging), which takes an integer and i thought the idea here was to calculate an approximate Date of Birth based on the Approximate Age?

image

On Editing the patient, the Date of birth field now has a value

image

Perhaps what we need is helper text to tell the user of the relationship between Date Of Birth, Unknown and Approximate Age fields?

@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Jul 9, 2020
@jackcmeyer jackcmeyer added good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module 🚀enhancement an issue/pull request that adds a feature to the application labels Jul 9, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Jul 9, 2020
@jackcmeyer
Copy link
Member

To close the loop on this:

I think the final requirement is merely a UI change, rather than a functionality change. The functionality we have now where checking unknown changes the input box to an integer input box for an estimate age is the desired behavior.

Hrugved added a commit to Hrugved/hospitalrun-frontend that referenced this issue Jul 9, 2020
Hrugved added a commit to Hrugved/hospitalrun-frontend that referenced this issue Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants