-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[WIP] feat(patient) secondary, tertiary addresses, phone numbers, and emails #2103
[WIP] feat(patient) secondary, tertiary addresses, phone numbers, and emails #2103
Conversation
A Feature that adds the ability to define secondary, tertiary, etc. phone numbers, addresses, and emails for a patient. New Feature HospitalRun#1920
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/ckm8w3x1l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design changes:
Create Patient
- When creating a new patient, I think that the everything should be inside the table rather than having a table only for the already added phone numbers. So, the page loads with the email, phone number, etc tables already loaded and there are empty boxes inside the table. (I hope that makes sense).
- I think the button should be on the bottom right side of the table since that is the order a user would work in
- I think the buttons should say "Add Email, "Add Phone Number", etc.
View Patient
- When viewing a patient, there should be no add buttons. Only the tables should be seen here.
Both
- I think the tables should render inside a panel that better distinguishes what the table means. The heading of the panel should be "Address", "Email", etc.
Design Changes for Phone Number, Email and Address Model fix HospitalRun#1920
@jackcmeyer I have made the design changes that you suggested Please let me know if there are any Modifications or Changes required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more design changes:
- I think the button format should be in the link styling to be a little smaller.
- The button should be outside of the table in the of the table, that way the table content takes up the whole panel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the number of review comments, mostly around:
- duplicate code
- internationalization of keys
- we'll need to get tests added for the new functionality, plus update any existing tests
Please let me know anything I can do to help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sourabbanka22 tests have dropped too far, exceeding our maximum limit to accept a PR. I'd ask you to check it out and fix it.
@tehkapa I am working on fixing the tests |
Some Bug Fixes and Tests Updated fix HospitalRun#1920
Component Instances for Phone Numbers, Addresses and Emails re HospitalRun#1920
Hi @kumikokashii , I have created component instances for Phone Numbers, Emails and Addresses, does the code look good to you? @tehkapa I have added all the required tests for the Added Functionalities, please let me know if there is anything else that I can help with |
@sourabbanka22 Thank you for the updates 🙏 It's looking almost ready to go. I'm gonna jump in and tweak it a bit. Please stay tuned. Thanks again! |
In addition to allowing more than one phone number, etc, updating the |
A Feature that adds the ability to define secondary, tertiary, etc. phone numbers, addresses, and
emails for a patient.
New Feature #1920
Fixes #1920 .
Below are some Screenshots of the Added Functionality:
Before Adding PhoneNumber and Email of a Patient:
After Adding PhoneNumber and Email:
User needs to click on the Add Button to add phone numbers, emails, etc to the respective array.
Currently I have commented out few tests related to Phone Number, Email and Address Models
Please let me know if there are any Modifications or Changes required.