Secondary, tertiary (etc) addresses, phone numbers, and emails for a patient

[jackcmeyer]

🚀 Feature Proposal

I would like the ability to define secondary, tertiary, etc. phone numbers, addresses, and emails for a patient.

When creating a new patient or editing patient, I should be able to add these extra fields.

It should also be able to label what kind of phone number, address, or email it is.

Phone numbers can be one of the following:

• home
• work
• temp
• old
• mobile

Email can be one of the following:

• home
• work
• temp
• old
• mobile

Addresses can one of the following:

• home
• work
• temp
• old
• billing

Motivation

We should be flexible in the type of data that can handle.

Example

• Apple Contacts

Technical notes

• Will require changes to the Patient model to support a list of addresses, phone numbers, emails.
• Will require changes to some models to support the label of the phone number, address, or email (in some cases it might even require creating new models).

[alti21]

May I help on this?

[jackcmeyer]

I've assigned this to you, @alti21. Please reach out if you have any questions!

[alti21]

@jackcmeyer I'm having some trouble with this. I'm quite new to typescript just to let you know. I'm having trouble with this: Will require changes to the Patient model to support a list of addresses, phone numbers, emails. I changed phoneNumber into an array in ContactInformation.ts:

export default interface ContactInformation { phoneNumber: string[], email?: string, address?: string }
Sorry i'm not sure how to add a line break to the code here

But then when I try to access patient.phonenumber[0] in GeneralInformation.ts, I get an error saying that patient.phoneNumber is undefined

[jackcmeyer]

You have the right idea for adding how to define the phone numbers as an array.

I'm guessing that the patient that you are looking at has no phone numbers defined for them.

If that's the case, then patient.phoneNumber is undefined.

When using an array accessor on undefined, you'll receive the error that you are getting.

Before accessing the patient's phoneNumber you'll want to check first its not undefined.

[alti21]

@jackcmeyer thanks for the help, I got that part figured out now. I do need some help with the translations, as I want to have different labels for the new fields. Is there a file that has the translations?

[sourabbanka22]

Hi @jackcmeyer, May I work on this issue?

[jackcmeyer]

@sourabbanka22 I've assigned this to you!

[sourabbanka22]

Hi , @jackcmeyer I have implemented the feature to define secondary, tertiary, etc. phone numbers, addresses, and emails for a patient.

Following are some screenshots of the implemented functionality:

Initial:

After Adding PhoneNumber and Email:

Adding Multiple PhoneNumbers, etc

Does this look OK to you?

[matteovivona]

@lauggh @StefanoMiC

[jackcmeyer]

@sourabbanka22 could you open a PR that can build so we can play around on the preview?

[sourabbanka22]

@jackcmeyer as I have made quite a few number of changes in the Patient model to support a list of addresses, phone numbers, emails also some additional changes to some models to support the label of the phone number, address, or email because of which some tests requires to be updated accordingly, I would require some help with that. Should I open a PR with these Test Cases failing?

[sourabbanka22]

@jackcmeyer I just opened a PR, Currently I have commented out a few tests related to newly created Phone Number, Email and Address Models

Please let me know if there are any Modifications or Changes required.

[lauggh]

Screenshots look good.

[ghost]

Hi, PR is ready for your review at #2113. Thank you!