This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(patients): fixes search when using special characters #2012
Merged
Merged
Changes from 18 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
1f19bb8
npm yarn install
JDarke 1d922c7
fix(src/components/input/textfieldwithlabelformgroup.tsx): update Label
JDarke 7efe678
revert(package.json): remove yarn listing
JDarke c7dba69
Merge branch 'master' into master
ba91b21
Merge branch 'master' into master
404a7a2
Merge branch 'master' into master
6a2523c
Merge branch 'master' into master
9f8c1d7
Merge branch 'master' into master
9bfb378
Merge branch 'master' into master
71cd8b0
Merge branch 'master' into master
8cac332
Merge branch 'master' into master
92ad7f7
Merge branch 'master' into master
b7e355a
Merge branch 'master' into master
36b889e
test(textfieldwithlabelformgroup.test.tsx): add test to Label isRequired
JDarke 7791d9e
refactor(textfieldwithlabelformgroup.test.tsx): make props semantic
JDarke add9c02
fix(patientrepository.ts): clean the search string of illegal chars
JDarke 57144a2
fix(patientrepository.ts): clean search string of illegal chars
JDarke 0ffef66
fix(patientrepository.ts): clean search string of special chars
JDarke 3354e9f
Merge branch 'master' into master
7cfaf06
Merge branch 'master' into master
a6e9be3
Merge branch 'master' into master
ee2f4d6
Merge branch 'master' into master
6b56390
Merge branch 'master' into master
b147cae
Merge branch 'master' into master
14c71f8
Merge branch 'master' into master
8b044e5
Merge branch 'master' into master
fccc145
test(patientrepository.test.ts): add test for search string clean regex
JDarke 1f97dff
test(src/__tests__/clients/db/patientrepository.test.ts): add test
JDarke 7347207
revert(package.json): undo mocha dependency in package.json
JDarke 1d2c485
Merge branch 'master' into master
df737ec
Merge branch 'master' into master
7e63752
Merge branch 'master' into master
f3ec82a
Merge branch 'master' into master
5214a4c
Merge branch 'master' into master
6b5b30b
Merge branch 'master' into master
f830e3d
Merge branch 'master' into master
d2314da
Merge branch 'master' into master
234b125
Merge branch 'master' into master
b603dd1
fix(src/clients/db/patientrepository.ts): add escapeStringRegex package
JDarke bb1af60
Merge branch 'master' of https://github.com/JDarke/hospitalrun-frontend
JDarke d8be269
Merge branch 'master' into master
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also checked with String
{1}
.SyntaxError: Invalid regular expression: /{1}/: Nothing to repeat.
Can you please handle this case as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should also remove
]
, and{
, and}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we need to remove all valid regex chars. Is there any lib out there that can help us to not forget any char?