This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
fix(patients): fixes search when using special characters #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason field on new appointment screen no longer a required field. Line 21, Label element now takes isRequired attr from interface Props. fix HospitalRun#1997
Previously added a listing for yarn in the dependencies in package.json. This commit undoes that. re |
Added a test case to test if the Label receives the isRequired prop on required fields re HospitalRun#2003
Changed const expectedValue to const expectedRequired, named for prop isRequired re HospitalRun#2003
Added a step to take the search string and remove all non-letter/whitespace characters. Line 16 and 22 fix HospitalRun#1999
Added a step to remove all non-alphabetical and whitespace characters from search string regex fix HospitalRun#1999
Removed special chars that interfered with RegExp in search strings re HospitalRun#1999
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/6fxtwuuth |
akshay-ap
suggested changes
Apr 24, 2020
src/clients/db/PatientRepository.ts
Outdated
| @@ -13,12 +13,13 @@ export class PatientRepository extends Repository<Patient> { | |||
| } | |||
|
|
|||
| async search(text: string): Promise<Patient[]> { | |||
| const cleanText = text.replace(/[\\[()?*]+/g, '') | |||
There was a problem hiding this comment.
I also checked with String {1}.
SyntaxError: Invalid regular expression: /{1}/: Nothing to repeat.
Can you please handle this case as well?
There was a problem hiding this comment.
I think that we should also remove ], and {, and }
There was a problem hiding this comment.
I think that we need to remove all valid regex chars. Is there any lib out there that can help us to not forget any char?
matteovivona
added
the
in progress
|
|
Added escapeStringRegexp package to escape special chars in search string for p fix HospitalRun#1999
jackcmeyer
approved these changes
Apr 30, 2020
jackcmeyer
added
patients
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1999.
Search string in patient search field is now cleaned of any breaking special characters.
Removes any number of occurrences of these chars:
[*?()