Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

style(component): Change New Related Person Button to Add : #1856 #1954

Closed
wants to merge 2 commits into from
Closed

style(component): Change New Related Person Button to Add : #1856 #1954

wants to merge 2 commits into from

Conversation

hemantpandey17
Copy link
Contributor

@hemantpandey17 hemantpandey17 commented Mar 31, 2020 •
edited by matteovivona
Loading

Added label in English for Add Related person button, Added label to modal and renamed
NewRelatedPersonModal to AddRelatedPersonModal

fix #1856

Fixes #1856

Changes proposed in this pull request:

  • Change the New Related Person button text to Add Related Person in the Patient's Related Persons tab so that it is consistent and more accurately reflects what the button is doing.
  • Change the Modal Title
  • Change the Modal submit button
  • Refactor component name from NewRelatedPersonModal to AddRelatedPersonModal

@hemantpandey17
style(component): change New Related Person Button to Add : HospitalR…
8f100d3 
…un#1856

Added label in English for Add Related person button, Added label to modal and renamed
NewRelatedPersonModal to AddRelatedPersonModal

fix HospitalRun#1856
@jsf-clabot
Copy link

jsf-clabot commented Mar 31, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Hemant Pandey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@vercel
Copy link

vercel bot commented Mar 31, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/7yg7ruyjq
✅ Preview: https://hospitalrun-frontend-git-fork-hemantpandey17-master.hospitalrun.now.sh

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Mar 31, 2020
@matteovivona matteovivona added this to the v2.0 milestone Mar 31, 2020
@matteovivona matteovivona requested review from jackcmeyer and a team March 31, 2020 17:38
fox1t
fox1t previously approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemantpandey17
Copy link
Contributor Author

Already signed CLA but looks like it is not picking it

@hemantpandey17 hemantpandey17 reopened this Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer approved these changes

@fox1t fox1t fox1t left review comments

Assignees
No one assigned
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Change New Related Person to Add Related Person
5 participants
@hemantpandey17 @jsf-clabot @fox1t @jackcmeyer @matteovivona