Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Change New Related Person to Add Related Person #1856

Closed
jackcmeyer opened this issue Feb 25, 2020 · 8 comments · Fixed by #1955
Closed

Change New Related Person to Add Related Person #1856

jackcmeyer opened this issue Feb 25, 2020 · 8 comments · Fixed by #1955
Assignees
@hemantpandey17
Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Feb 25, 2020 •
edited
Loading

  • Change the New Related Person button text to Add Related Person in the Patient's Related Persons tab so that it is consistent and more accurately reflects what the button is doing.

  • Change the Modal Title

  • Change the Modal submit button

This also goes for

Technical Notes

  • Refactor component name from NewRelatedPersonModal to AddRelatedPersonModal
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application patients issue/pull request that interacts with patients module labels Feb 25, 2020
@jackcmeyer jackcmeyer added this to the v2.0.0 milestone Feb 25, 2020
@jackcmeyer jackcmeyer added good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions labels Feb 25, 2020
@tallskys
Copy link

I'd like to help with this

@jackcmeyer
Copy link
Member Author

@tallskys Sounds great, I've assigned this to you!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Feb 26, 2020
@mgm793
Copy link

mgm793 commented Mar 16, 2020

Is this task done?

@matteovivona
Copy link
Contributor

Hi @mgm793 no, but it's already been assigned. Thank you anyway for your interest.

@fox1t
Copy link
Member

fox1t commented Mar 23, 2020

Any news on this, @tallskys?

@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions and removed in progress indicates that issue/pull request is currently being worked on labels Mar 28, 2020
@oizuldan
Copy link
Contributor

I'd like to do this task

@hemantpandey17
Copy link
Contributor

hemantpandey17 commented Mar 30, 2020 •
edited
Loading

I can work on this. Will help me to onboard on the project and work on more complex issues later.

@jackcmeyer
Copy link
Member Author

@oizuldan, since you have another issue in progress, I'm assigning this to @Hemantpandey1!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 31, 2020
hemantpandey17 added a commit to hemantpandey17/hospitalrun-frontend that referenced this issue Mar 31, 2020
@hemantpandey17
style(component): change New Related Person Button to Add : HospitalR…
8f100d3 
…un#1856

Added label in English for Add Related person button, Added label to modal and renamed
NewRelatedPersonModal to AddRelatedPersonModal

fix HospitalRun#1856
This was referenced Mar 31, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hemantpandey17 hemantpandey17

Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
7 participants
@fox1t @matteovivona @mgm793 @hemantpandey17 @jackcmeyer @oizuldan @tallskys