Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(patients): better form feedback for add allergy #1945

Merged
merged 5 commits into from
Mar 29, 2020
Merged

feat(patients): better form feedback for add allergy #1945

merged 5 commits into from
Mar 29, 2020

Conversation

cfiorini74
Copy link
Contributor

Fixes #1924.

@cfiorini74
feat(newallergymodel.tsx and english index.ts): fix for issue Hospita…
57541a8 
…lRun#1924

Changes made in NewAllergyModel.tsx for two new hooks to store isInvalid boolean and textInput
feedback. Additional error added to allergies in English index.ts

fix HospitalRun#1924
@jsf-clabot
Copy link

jsf-clabot commented Mar 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Mar 26, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/c3qc2qotk
✅ Preview: https://hospitalrun-frontend-git-fork-cfiorini74-master.hospitalrun.now.sh

jackcmeyer
jackcmeyer approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One code change and some test fixing, then this PR should be good to go!

src/patients/allergies/NewAllergyModal.tsx Outdated Show resolved Hide resolved
@jackcmeyer jackcmeyer self-requested a review March 26, 2020 17:41
jackcmeyer
jackcmeyer suggested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One code change and some test fixing, then this PR should be good to go!

@jackcmeyer jackcmeyer changed the title Fix for issue #1924 feat(patients): better form feedback for add allergy Mar 26, 2020
@cfiorini74
style(newallergymodal.tsx): change variable names in NewAllergyModal.tsx
b0d61d1 
Change names of boolean which stores if input is invalid in NewAllergyModal.tsx for clarity

fix HospitalRun#1924
@cfiorini74 cfiorini74 requested a review from jackcmeyer March 27, 2020 18:44
@jackcmeyer
Copy link
Member

Hi @cfiorini74, the good is looking good! However, the tests are still failing. Please let me know if you need any help resolving the failing tests!

@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 28, 2020
@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application patients issue/pull request that interacts with patients module labels Mar 28, 2020
@jackcmeyer jackcmeyer requested a review from fox1t March 28, 2020 00:38
@cfiorini74
fix(newallergymodel.test.tsx): change variable in newallergymodel test
d06b9df 
Changes variable in test for newallergymodel as String for the alert in actual newallergymodel.tsx
has been changed.

fix HospitalRun#1924
@jackcmeyer
Copy link
Member

LGTM! Thanks for the PR, @cfiorini74

@jackcmeyer jackcmeyer merged commit d6904e7 into HospitalRun:master Mar 29, 2020
@cfiorini74 cfiorini74 mentioned this pull request Apr 20, 2020
Closed
@jackcmeyer jackcmeyer linked an issue Apr 21, 2020 that may be closed by this pull request
Add Allergy should provide better error feedback #1924
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer approved these changes

@fox1t fox1t Awaiting requested review from fox1t

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add Allergy should provide better error feedback
3 participants
@cfiorini74 @jsf-clabot @jackcmeyer