This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Allergy should provide better error feedback #1924
Labels
🚀enhancement
an issue/pull request that adds a feature to the application
good first issue
indicates an issue is good for a first time contributor
in progress
indicates that issue/pull request is currently being worked on
patients
issue/pull request that interacts with patients module
Milestone
Comments
jackcmeyer
added
🚀enhancement
an issue/pull request that adds a feature to the application
good first issue
indicates an issue is good for a first time contributor
help wanted
indicates that an issue is open for contributions
patients
issue/pull request that interacts with patients module
labels
Mar 19, 2020
Hi Jack, |
Sounds good, I've assigned this to you, @cfiorini74. |
jackcmeyer
added
in progress
indicates that issue/pull request is currently being worked on
and removed
help wanted
indicates that an issue is open for contributions
labels
Mar 21, 2020
cfiorini74
added a commit
to cfiorini74/hospitalrun-frontend
that referenced
this issue
Mar 26, 2020
…lRun#1924 Changes made in NewAllergyModel.tsx for two new hooks to store isInvalid boolean and textInput feedback. Additional error added to allergies in English index.ts fix HospitalRun#1924
cfiorini74
added a commit
to cfiorini74/hospitalrun-frontend
that referenced
this issue
Mar 26, 2020
Change names of boolean which stores if input is invalid in NewAllergyModal.tsx for clarity fix HospitalRun#1924
cfiorini74
added a commit
to cfiorini74/hospitalrun-frontend
that referenced
this issue
Mar 29, 2020
Changes variable in test for newallergymodel as String for the alert in actual newallergymodel.tsx has been changed. fix HospitalRun#1924
Is it still on ? |
@hemantpandey17 looks like this still available. Would you like to complete it still? Sorry I missed this message. |
I can take that. |
I think I might have done this feature already in this pull request. Wasn't sure how to directly link it with this issue, sorry. |
Confirmed that the PR @cfiorini74 linked closes this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🚀enhancement
an issue/pull request that adds a feature to the application
good first issue
indicates an issue is good for a first time contributor
in progress
indicates that issue/pull request is currently being worked on
patients
issue/pull request that interacts with patients module
🚀 Feature Proposal
I would like the add allergy modal to provide better feedback for error messages.
Currently, the only error message is a banner error message.
After the completion of this issue, I would like it to provide feedback at the field level when possible.
The following should happen:
Name is required.
Unable to add allergy.
.Motivation
Better user experience.
The text was updated successfully, but these errors were encountered: