Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix for Dockerfile issues building on CentOs 7. See issue #1081 #1082

Merged
merged 3 commits into from
May 18, 2017
Merged

Fix for Dockerfile issues building on CentOs 7. See issue #1081 #1082

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4a2eb3
Fix for Dockerfile issues building on CentOs 7. See issue #1081
RonanOD May 10, 2017
c4084d9
Improved fix based on @jkleinsc suggestions
RonanOD May 11, 2017
c4b1251
Merge branch 'master' into Fix1081
jkleinsc May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ RUN apt-get update && apt-get install nodejs -y
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
COPY . /usr/src/app
RUN npm install -g npm && npm install -g ember-cli@latest && npm install -g bower
RUN npm install
RUN npm install -g ember-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only fix needed here is to remove the npm install -g npm.

RUN latest && npm install -g bower
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest should have been on the previous line (eg npm install -g ember-cli@latest)

#RUN npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is needed to run HospitalRun

RUN bower install --allow-root
COPY ./server/config-example.js ./server/config.js

Expand Down