This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix for Dockerfile issues building on CentOs 7. See issue #1081 #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
suggested changes
May 11, 2017
Dockerfile
Outdated
| @@ -9,8 +9,9 @@ RUN apt-get update && apt-get install nodejs -y | |||
| RUN mkdir -p /usr/src/app | |||
| WORKDIR /usr/src/app | |||
| COPY . /usr/src/app | |||
| RUN npm install -g npm && npm install -g ember-cli@latest && npm install -g bower | |||
| RUN npm install | |||
| RUN npm install -g ember-cli | |||
There was a problem hiding this comment.
I think the only fix needed here is to remove the npm install -g npm.
Dockerfile
Outdated
| RUN npm install -g npm && npm install -g ember-cli@latest && npm install -g bower | ||
| RUN npm install | ||
| RUN npm install -g ember-cli | ||
| RUN latest && npm install -g bower |
There was a problem hiding this comment.
The latest should have been on the previous line (eg npm install -g ember-cli@latest)
Dockerfile
Outdated
| RUN npm install | ||
| RUN npm install -g ember-cli | ||
| RUN latest && npm install -g bower | ||
| #RUN npm install |
There was a problem hiding this comment.
This line is needed to run HospitalRun
|
Thanks @jkleinsc. Made the improvements you suggested and pushed to this branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1081
Changes proposed in this pull request:
Hi, I solved my difficulties with building the HospitalRun docker image by making these slight changes to the Dockerfile. Hopefully they are acceptable, if not can you let me know what else I should do to get this working.
Thanks
@tangollama
cc @HospitalRun/core-maintainers