node@14: use brewed/system libraries#86512
Closed
Bo98 wants to merge 1 commit intoHomebrew:masterfrom
Closed
Conversation
309ed25 to
da1a1ea
Compare
carlocab
reviewed
Oct 5, 2021
carlocab
reviewed
Oct 5, 2021
Formula/node@14.rb
Outdated
Member
There was a problem hiding this comment.
We should check linkage with libuv when the bottles are built. Node had a bug where it didn't link properly with libuv (#76893). Not sure if the fix was ever backported. I don't think I tracked down the exact fix, but I think it happened between 16.4 and 16.5.
Member
Author
There was a problem hiding this comment.
Big Sur arm64 and x86_64 bottles:
bottles/node@14/14.18.0_1/bin/node:
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
@@HOMEBREW_PREFIX@@/opt/libuv/lib/libuv.1.dylib (compatibility version 2.0.0, current version 2.0.0)
I think that means it's ok?
da1a1ea to
aba598f
Compare
SMillerDev
approved these changes
Oct 5, 2021
carlocab
approved these changes
Oct 5, 2021
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This backports the changes made in our Node 16 formula.
I'm hoping this also fixes the
ZlibErrorissue in macOS 11.6 - we'll see.