Skip to content

node@14: use brewed/system libraries#86512

Closed
Bo98 wants to merge 1 commit intoHomebrew:masterfrom
Bo98:node@14-brewed-libs
Closed

node@14: use brewed/system libraries#86512
Bo98 wants to merge 1 commit intoHomebrew:masterfrom
Bo98:node@14-brewed-libs

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Oct 5, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This backports the changes made in our Node 16 formula.

I'm hoping this also fixes the ZlibError issue in macOS 11.6 - we'll see.

@BrewTestBot BrewTestBot added the legacy Relates to a versioned @ formula label Oct 5, 2021
@Bo98 Bo98 force-pushed the node@14-brewed-libs branch from 309ed25 to da1a1ea Compare October 5, 2021 16:54
Copy link
Copy Markdown
Member

@carlocab carlocab Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check linkage with libuv when the bottles are built. Node had a bug where it didn't link properly with libuv (#76893). Not sure if the fix was ever backported. I don't think I tracked down the exact fix, but I think it happened between 16.4 and 16.5.

Copy link
Copy Markdown
Member Author

@Bo98 Bo98 Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Sur arm64 and x86_64 bottles:

bottles/node@14/14.18.0_1/bin/node:
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	@@HOMEBREW_PREFIX@@/opt/libuv/lib/libuv.1.dylib (compatibility version 2.0.0, current version 2.0.0)

I think that means it's ok?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's fine.

@Bo98 Bo98 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 5, 2021
@Bo98 Bo98 force-pushed the node@14-brewed-libs branch from da1a1ea to aba598f Compare October 5, 2021 18:26
@BrewTestBot
Copy link
Copy Markdown
Contributor

:shipit: @Bo98 has triggered a merge.

@Bo98 Bo98 mentioned this pull request Oct 6, 2021
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. legacy Relates to a versioned @ formula outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants