Skip to content

node(@*): fix test#86090

Closed
Bo98 wants to merge 3 commits intoHomebrew:masterfrom
Bo98:node-test
Closed

node(@*): fix test#86090
Bo98 wants to merge 3 commits intoHomebrew:masterfrom
Bo98:node-test

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Sep 28, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

bufferutils now builds a universal binary. This does not work on older macOS (like Mojave) as the compiler does not support -arch arm64, but also breaks on newer macOS as we pass arch-specific flags such as -march as CFLAGS in the test environment.

Homebrew/discussions#2211

@Bo98 Bo98 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Sep 28, 2021
@carlocab carlocab added the test failure CI fails while running the test-do block label Sep 29, 2021
@derrabus derrabus mentioned this pull request Sep 29, 2021
@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Sep 29, 2021

Bit odd:

ZlibError: zlib: incorrect data check

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Sep 29, 2021

I'm guessing this is revealing something already broken. The difference with older node is that we aren't using our zlib (or rather the system's on macOS) - we should fix that.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Oct 3, 2021

I removed the failing test from node@14 in #86046 to avoid delaying the version update for a problem in our testing environment.

@Bo98
Copy link
Copy Markdown
Member Author

Bo98 commented Oct 6, 2021

Node 16 fix bundled in with #86291.
Node 14 fixed in #86512.
Node 12 fixed in #86526.

@Bo98 Bo98 closed this Oct 6, 2021
@Bo98 Bo98 deleted the node-test branch October 6, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. test failure CI fails while running the test-do block

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants