-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
azure-cli: migrate to [email protected] #78022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
carlocab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @bsiegel. However, I believe azure-cli isn't compatible with Python3.9 yet. (e.g. Azure/azure-cli#15580)
azure-cli's automated release workflow will just switch this back to Python3.8 at the next version bump. See:
https://github.com/Azure/azure-cli/blob/dev/scripts/release/homebrew/docker/formula_template.txt
Azure/azure-cli#15482
#62253
#62785
|
Ah, okay. The tracking issue for Python 3.9 support (Azure/azure-cli#16611) was closed and the release notes for 2.24.0 mention Python 3.9 support so I believe the tool itself is now ready for Python 3.9. However as you point out the automation seems like it will just overwrite this change, so it sounds like the right thing to do will be to open a PR to update the automation in the azure-cli repo. |
|
I've opened Azure/azure-cli#18224 to update the formula template |
|
Great, this should be good then once Azure/azure-cli#18224 is merged. Thanks for working on that. |
|
This needs rebasing after #78459. (With |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Still pending merge of the blocking PR in the azure-cli repo. Looks like it -may- be scheduled for completion this month. |
|
We have merged Azure/azure-cli#18224. Please go ahead and merge this PR. Thanks!! |
|
Oops, this doesn't work. Let me try something else. |
|
Cherry-picked the changes here onto #83088. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?