-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc-arm-none-eabi 8-2019-q3-update (new formula) #45780
Conversation
Formula/gcc-arm-none-eabi.rb
Outdated
version "8-2019-q3-update" | ||
sha256 "e8a8ddfec47601f2d83f1d80c0600f198476f227102121c8d6a5a781d0c2eeef" | ||
|
||
env :std |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not acceptable in Homebrew core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Formula/gcc-arm-none-eabi.rb
Outdated
|
||
env :std | ||
|
||
depends_on "wget" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources shouldn't be downloaded by the build script behind our back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully fixed. I have to wait to find out if it builds with homebrews' versions of packages.
|
||
system "./install-sources.sh" | ||
system "./build-prerequisites.sh" | ||
system "./build-toolchain.sh", "--skip_steps=manual" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be made to build closer to arm-linux-gnueabihf-binutils
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly no. build-toolchain.sh
is a 952 line monster. Just the happy path is ~450. I don't think we want to reimplement it for homebrew and maintain future compatibility.
Hi @ProZsolt I'm sorry but the build process for this is simply not maintainable enough for us to accommodate in Homebrew core. You can ask for reinclusion in Homebrew casks given this cannot fit in core. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This was removed from cask (Homebrew/homebrew-cask#56802)