Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete gcc-arm-embedded.rb #56802

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Delete gcc-arm-embedded.rb #56802

merged 1 commit into from
Jan 9, 2019

Conversation

vitorgalvao
Copy link
Member

Isn’t this open source (and CLI-only)?

Is there a reason this can’t be moved to Homebrew?

@vitorgalvao vitorgalvao merged commit b3a2e0c into master Jan 9, 2019
@vitorgalvao vitorgalvao deleted the del-gcc-arm-embedded branch January 9, 2019 16:08
@vitorgalvao vitorgalvao removed awaiting maintainer feedback Issue needs response from a maintainer. discussion labels Jan 9, 2019
@alexeden
Copy link

alexeden commented Jan 10, 2019

@vitorgalvao @reitermarkus I was in the process of installing the necessary tools for working with embedded Rust, which requires this cask. The documentation specifies the command brew cask install gcc-arm-embedded which obviously failed, and that led me here.

My knowledge of Homebrew in general is limited... is there an alternative means via brew by which I can get this package?

@jymoulin
Copy link

Why was it deleted ? Just because of gdb ? Why not fall back to previous version ?

@vitorgalvao
Copy link
Member Author

Why was it deleted ?

Because it should be a formula, not a cask, as it is a CLI-only open-source tool. This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core as a formula that builds from source. If it is rejected, you may then try again as a cask (link us to the issue so we can see the discussion and reasoning for rejection).

In an ideal world, we could have opened this PR for removal and have merged it only after the formula is made. In the real world, however, it has been shown to us time and time again that had we done that, this removal PR would’ve been open indefinitely. No matter where we post these notices (here, twitter), people only react after it’s gone.

Occasionally it’s then we see that we should’ve kept it and revert the decision, but removing ends up being the right choice nine times out of ten (if not more). For now, this should be a formula and you should direct your efforts in that regard.

The documentation specifies the command brew cask install gcc-arm-embedded

That’s unfortunate. Naturally, we can’t know everywhere our commands are used as documentation, and so can sometimes cause unwanted breakage. This might be an opportunity, though. Maybe they (or someone in the community) will want to create the formula.

@reitermarkus
Copy link
Member

@alexeden, I'm using https://github.com/rust-embedded/cross. I just added macOS support to it recently.

HotelCalifornia referenced this pull request in purduesigbots/pros-docs Jan 13, 2019
claui added a commit to claui/homebrew-cask-public that referenced this pull request Jan 24, 2019
This is a temporary fix for [1] until the proper formula will be
added to homebrew-core proper.

[1]: Homebrew/homebrew-cask#56802
haata added a commit to kiibohd/controller that referenced this pull request Jan 26, 2019
- cask gcc-arm-embedded package was removed
  Homebrew/homebrew-cask#56802
- Now using armmbed/formulae
haata added a commit to kiibohd/controller that referenced this pull request Jan 26, 2019
- cask gcc-arm-embedded package was removed
  Homebrew/homebrew-cask#56802
- Now using armmbed/formulae
@machinaut
Copy link

I ran into this (like many other folks) because I'm trying to install gcc-arm-embedded while it is in limbo -- removed from cask but not yet added to core.

The cask installer can take a URL to a script, and you can point it at the commit before this file like so

brew cask install https://raw.githubusercontent.com/Homebrew/homebrew-cask/b88346667547cc85f8f2cacb3dfe7b754c8afc8a/Casks/gcc-arm-embedded.rb

Hopefully this is useful who came here looking for a temporary solution to brew cask install gcc-arm-embedded.

@vitorgalvao
Copy link
Member Author

removed from cask but not yet added to core.

Which so far just supports my earlier point, so it’ll stay removed for now.

@tannewt
Copy link
Contributor

tannewt commented Feb 15, 2019

Is anyone working on a core brew formula?

@vitorgalvao
Copy link
Member Author

@tannewt I doubt it. If you want to do it, you should go ahead.

@lock lock bot added the outdated label Mar 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 20, 2019
@fxcoudert
Copy link
Member

FYI: this was rejected from Homebrew core, due to a build process that is way to difficult for us to accommodate Homebrew/homebrew-core#45780

@vitorgalvao
Copy link
Member Author

#75091

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants