Skip to content

thrift 0.12.0 #35796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taraspos wants to merge 3 commits into from
Closed

thrift 0.12.0 #35796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc687a0
thrift 0.12.0
taraspos Jan 8, 2019
a42a38a
Removing the seldom-used options, per #31510
fxcoudert Jan 8, 2019
fbb7565
bump osquery revision
taraspos Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 Aliases/thrift@0.11 → Aliases/thrift@0.12
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions Formula/osquery.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ class Osquery < Formula
homepage "https://osquery.io"
url "https://github.com/facebook/osquery/archive/3.3.2.tar.gz"
sha256 "74280181f45046209053a3e15114d93adc80929a91570cc4497931cfb87679e4"
revision 1

bottle do
cellar :any
Expand Down
6 changes: 4 additions & 2 deletions Formula/thrift.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Thrift < Formula
desc "Framework for scalable cross-language services development"
homepage "https://thrift.apache.org/"
url "https://www.apache.org/dyn/closer.cgi?path=/thrift/0.11.0/thrift-0.11.0.tar.gz"
sha256 "c4ad38b6cb4a3498310d405a91fef37b9a8e79a50cd0968148ee2524d2fa60c2"
url "https://www.apache.org/dyn/closer.cgi?path=/thrift/0.12.0/thrift-0.12.0.tar.gz"
sha256 "c336099532b765a6815173f62df0ed897528a9d551837d627c1f87fadad90428"

bottle do
cellar :any
Expand Down Expand Up @@ -36,9 +36,11 @@ def install
--with-openssl=#{Formula["openssl"].opt_prefix}
--without-erlang
--without-haskell
--without-java
Copy link
Contributor

@Fokko Fokko Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing Java, I think it is important to have the Java bindings. If so, you need to remove the env-settings as well.

Copy link
Member

@SMillerDev SMillerDev Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barely anyone uses it based on the analytics above and it pulls in a huge dependency, I'd say this is a valid reason to remove it.

--without-perl
--without-php
--without-php_extension
--without-python
--without-ruby
--without-java
--without-python
Expand Down