thrift 0.12.0

[taraspos]

• ✅Have you followed the guidelines for contributing?
• ✅ Have you checked that there aren't other open pull requests for the same formula update/change?
• ✅ Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• ✅ Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• ✅Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

[fxcoudert]

• Please squash both commits into a single one, thrift 0.12.0
• Add to this commit a rename of Aliases/thrift@0.11 to Aliases/thrift@0.12
• In a second commit, bump revision of osquery

[taraspos]

@fxcoudert
thanks for the feedback, will do.
But I didn't get the one about osquery.
Do you mean update https://github.com/Homebrew/homebrew-core/blob/master/Formula/osquery.rb to 3.3.1?

[taraspos]

About the osquery, it is not published on the official downloads page yet https://osquery.io/downloads/official, and I can't find the sha256for the package anywhere else.

[fxcoudert]

I mean in osquery, bump revision 1 to revision 2, in a separate commit with title osquery: revision for thrift

[taraspos]

All done

[fxcoudert]

Removing the seldom-used options, per #31510

==> install (30 days)
Index | Name (with options)                                   | Count |  Percent
-----:|-------------------------------------------------------|------:|--------:
1     | thrift                                                | 1,439 |   97.30%
2     | thrift --HEAD                                         |    21 |    1.42%
3     | thrift --with-java                                    |     7 |    0.47%
4     | thrift --with-python@2                                |     7 |    0.47%

[fxcoudert]

osquery build failure…

[taraspos]

@fxcoudert any ideas what can be done here? 😕

[SMillerDev]

related to #35941

[Fokko]

Why are you removing Java, I think it is important to have the Java bindings. If so, you need to remove the env-settings as well.

[SMillerDev]

Barely anyone uses it based on the analytics above and it pulls in a huge dependency, I'd say this is a valid reason to remove it.

[Fokko]

Any update on this?

[adamlc]

Would love an update if there is one 👍

[linguofeng]

Any updates?

[taraspos]

Sorry guys, I have no idea what I can do here. The most I can try is to rerun the build, maybe it will work now ¯_(ツ)_/¯.

The upstream issue seems to be ignored.

[fxcoudert]

The osquery build should be fixed with the new version: 8b42b60

Can you:

• rebase the thrift update onto master?
• bump the osquery revision, in a separate commit?

That should do the trick

[fxcoudert]

Thanks @trane9991 ! 🍸