protobuf: fix --with-python build with Python 3.7#34478
Merged
fxcoudert merged 1 commit intoHomebrew:masterfrom Nov 27, 2018
Merged
protobuf: fix --with-python build with Python 3.7#34478fxcoudert merged 1 commit intoHomebrew:masterfrom
fxcoudert merged 1 commit intoHomebrew:masterfrom
Conversation
If built using --with-python, compilation fails with Python 3.7 because the Python folks changed their C API such that PyUnicode_AsUTF8AndSize() now returns a const char* rather than a char*. Add a patch to work around. This is the same patch that was applied for protobuf 3.6.1 in Homebrew#29660. That patch was removed in the upgrade of the formula to protobuf 3.6.1.1 in Homebrew/homebrew-core@3a6b38b6, perhaps because it was incorrectly assumed the patch was incorporated upstream in the 3.6 branch.
Closed
Member
|
Thanks @benmwebb |
Contributor
|
Thank your for you elaboration. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If built using
--with-python, compilation fails with Python 3.7 because the Python folks changed their C API such thatPyUnicode_AsUTF8AndSize()now returns aconst char*rather than achar*. Add a patch to work around.This is the same patch that was applied for protobuf 3.6.1 in #29660. That patch was removed in the upgrade of the formula to protobuf 3.6.1.1 in 3a6b38b6, perhaps because it was incorrectly assumed the patch was incorporated upstream in the 3.6 branch.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?