protobuf: add Python 3.7 compatibility#29660
Merged
ilovezfs merged 2 commits intoHomebrew:masterfrom Jul 4, 2018
Merged
Conversation
Contributor
Author
|
OK, I think I can do that. I was just following the example of OpenCV, which patches directly in the formula: 377ac4c. Figured that was the approved way to handle such issues. |
Contributor
Contributor
Author
|
Upstream PR: protocolbuffers/protobuf#4862. I can update this PR once the protobuf folks merge that (or otherwise fix Python 3.7), if that works best for you guys. |
Contributor
|
Just use |
Contributor
|
i.e. no need to wait |
If built using --with-python, compilation fails with Python 3.7 because the Python folks changed their C API such that PyUnicode_AsUTF8AndSize() now returns a const char* rather than a char*. Add a patch to work around.
Contributor
Author
|
OK, PR updated to use the upstream patch. |
ilovezfs
approved these changes
Jul 4, 2018
Contributor
|
Thanks @benmwebb! Shipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If built using --with-python, compilation fails with
Python 3.7 because the Python folks changed their C
API such that PyUnicode_AsUTF8AndSize() now returns
a const char* rather than a char*. Add a patch to
work around.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?