Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions Formula/g/genai-toolbox.rb → Formula/m/mcp-toolbox.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class GenaiToolbox < Formula
desc "MCP Toolbox for Databases, an open source MCP server for databases"
class McpToolbox < Formula
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to rename the formula? The project still seems to be called genai-toolbox.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an ask from the repo maintainers. They have plans of renaming the project to mcp-toolbox.
googleapis/genai-toolbox#936 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that when they do, otherwise it's just confusing. We can add an alias though

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev, all of their docs seem to be using the terminology mcp-toolbox or toolbox. Is creating an alias same as creating a new formula for the same artifact?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it just allows users to address the same formula by an additional name.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidance from https://docs.brew.sh/Homebrew-homebrew-core-Maintainer-Guide#naming says (emphasis mine):

Choose a name that’s the most common name for the project. For example, we initially chose objective-caml but we should have chosen ocaml. Choose what people say to each other when talking about the project.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough and makes sense. I'm going to open a separate PR to rename this properly and we'll get it merged.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- much appreciated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, much appreciated!

desc "Open source MCP server for databases"
homepage "https://github.com/googleapis/genai-toolbox"
url "https://github.com/googleapis/genai-toolbox/archive/refs/tags/v0.9.0.tar.gz"
sha256 "a18dd9e173ac008f725d7111b8d70b2053dfe99049795d73a74f38ac18227b21"
Expand All @@ -10,15 +10,6 @@ class GenaiToolbox < Formula
strategy :github_latest
end

bottle do
sha256 cellar: :any_skip_relocation, arm64_sequoia: "19f6dc79592239860bf263acf6415305d3b1bc4084dc823a543a353888e735ed"
sha256 cellar: :any_skip_relocation, arm64_sonoma: "19f6dc79592239860bf263acf6415305d3b1bc4084dc823a543a353888e735ed"
sha256 cellar: :any_skip_relocation, arm64_ventura: "19f6dc79592239860bf263acf6415305d3b1bc4084dc823a543a353888e735ed"
sha256 cellar: :any_skip_relocation, sonoma: "d3c6681281d19afedc28753085b6fa2ef3bc1802300dae995a237b7f22bf4faa"
sha256 cellar: :any_skip_relocation, ventura: "d3c6681281d19afedc28753085b6fa2ef3bc1802300dae995a237b7f22bf4faa"
sha256 cellar: :any_skip_relocation, x86_64_linux: "d7d83f9bbb5d627cdca667f903b5712de59e31057b0dbd978e9327d1557dccfd"
end

depends_on "go" => :build

def install
Expand Down
1 change: 1 addition & 0 deletions formula_renames.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"fcct": "butane",
"ffmpeg28": "ffmpeg@2.8",
"findbugs": "spotbugs",
"genai-toolbox": "mcp-toolbox",
"geode": "apache-geode",
"geth": "ethereum",
"gitlab-ci-multi-runner": "gitlab-runner",
Expand Down
Loading