mcp-toolbox: renamed from genai-toolbox#230824
mcp-toolbox: renamed from genai-toolbox#230824bpranava wants to merge 2 commits intoHomebrew:mainfrom
Conversation
github-actions
bot
added
the
automerge-skip
|
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
bpranava
force-pushed
the
delete-genai-toolbox
branch
from
aba1e7d to
1923769
Compare
|
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
Formula/m/mcp-toolbox.rb
Outdated
There was a problem hiding this comment.
Why do we need to rename the formula? The project still seems to be called genai-toolbox.
There was a problem hiding this comment.
It's an ask from the repo maintainers. They have plans of renaming the project to mcp-toolbox.
googleapis/genai-toolbox#936 (comment)
There was a problem hiding this comment.
We can do that when they do, otherwise it's just confusing. We can add an alias though
There was a problem hiding this comment.
@SMillerDev, all of their docs seem to be using the terminology mcp-toolbox or toolbox. Is creating an alias same as creating a new formula for the same artifact?
There was a problem hiding this comment.
No, it just allows users to address the same formula by an additional name.
There was a problem hiding this comment.
The guidance from https://docs.brew.sh/Homebrew-homebrew-core-Maintainer-Guide#naming says (emphasis mine):
Choose a name that’s the most common name for the project. For example, we initially chose objective-caml but we should have chosen ocaml. Choose what people say to each other when talking about the project.
There was a problem hiding this comment.
Fair enough and makes sense. I'm going to open a separate PR to rename this properly and we'll get it merged.
carlocab
force-pushed
the
delete-genai-toolbox
branch
from
1923769 to
0d24693
Compare
carlocab
left a comment
carlocab
left a comment
There was a problem hiding this comment.
Seems fine to me, but maybe it might be better to wait given https://github.com/Homebrew/homebrew-core/pull/230824/files#r2223322339
carlocab
force-pushed
the
delete-genai-toolbox
branch
from
0d24693 to
5d9fc5d
Compare
5 participants
Depends on #230744. Github was misinterpreting file deletion as a rename leading to CI failures. Hence I had to raise my changes on a separate branch.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?