opencv: modify CMake config to avoid Cellar paths#208051
Closed
opencv: modify CMake config to avoid Cellar paths#208051
Conversation
b107e2f to
8bb0970
Compare
This was referenced Feb 18, 2025
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Member
Author
|
Closing for now until we can resolve the protobuf patchelf issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew-specific workaround due to our symlink directory structure.
REALPATH would usually be the better option since it avoids other symlink issues (e.g. if you only symlink CMake files and then try to use those, they can end up using incorrect paths if
CMAKE_CURRENT_LIST_DIRisn't resolved first).In Homebrew, for standard layout, this isn't usually not an issue as we symlink all parts of keg. It mainly becomes an issue if using
libexecor other non-linked directories.Specifically to avoid having to patch these up afterwards like in
visp:homebrew-core/Formula/v/visp.rb
Lines 133 to 144 in dc51e30
homebrew-core/Formula/v/visp.rb
Lines 148 to 150 in dc51e30